[in_app_purchase_storekit] Add Swift Package Manager compatibility#8469
Merged
auto-submit[bot] merged 13 commits intoflutter:mainfrom Jan 29, 2025
Conversation
.../in_app_purchase_storekit/darwin/in_app_purchase_storekit/Sources/storekit_objc/messages.g.m
Outdated
Show resolved
Hide resolved
Collaborator
A number of the automated tests are not buildable in this PR. If you click into the failing CI tasks, click |
LouiseHsu
reviewed
Jan 21, 2025
...hase_storekit/Sources/in_app_purchase_storekit/StoreKit2/InAppPurchasePlugin+StoreKit2.swift
Show resolved
Hide resolved
Contributor
Author
|
I will fix tree issue tmr |
b71a757 to
99a1132
Compare
Contributor
Author
|
Hmm, I am not sure why the tree status is failing. I though it was because of the main merge in my branch. |
Collaborator
|
Contributor
Author
|
I see, thank you. |
…packages into feat/in-app-purchase-add-swift-package-manager-support
99a1132 to
f415bf0
Compare
Comment on lines
14
to
18
| #if __has_include(<in_app_purchase_storekit/in_app_purchase_storekit.h>) | ||
| @import in_app_purchase_storekit; | ||
| #else | ||
| @import storekit_objc; | ||
| #endif |
Contributor
Author
There was a problem hiding this comment.
I tried to avoid changing this file but I couldn't find a way.
Contributor
Author
|
Hey @loic-sharma, whenever you have a chance, could you review these changes, please? Thanks! |
Collaborator
|
@alejandro-all-win-software Per our contributor docs, you should expect a review within two weeks, not 24 hours; please don't ping people just because they haven't immediately reviewed a PR. |
loic-sharma
reviewed
Jan 24, 2025
packages/in_app_purchase/in_app_purchase_storekit/darwin/in_app_purchase_storekit/Package.swift
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...t/darwin/in_app_purchase_storekit/Sources/storekit_objc/Protocols/FLTMethodChannelProtocol.m
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...t/darwin/in_app_purchase_storekit/Sources/storekit_objc/Protocols/FLTMethodChannelProtocol.m
Outdated
Show resolved
Hide resolved
…in-app-purchase-add-swift-package-manager-support
loic-sharma
reviewed
Jan 24, 2025
...t/darwin/in_app_purchase_storekit/Sources/in_app_purchase_storekit_objc/FIAPReceiptManager.m
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
..._app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FIAPPaymentQueueDelegate.h
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...ces/in_app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FIAPReceiptManager.h
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
..._app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FLTMethodChannelProtocol.h
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...p_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FLTTransactionCacheProtocol.h
Show resolved
Hide resolved
loic-sharma
reviewed
Jan 24, 2025
...ces/in_app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FIAPReceiptManager.h
Outdated
Show resolved
Hide resolved
…in-app-purchase-add-swift-package-manager-support
loic-sharma
reviewed
Jan 27, 2025
..._app_purchase_storekit_objc/include/in_app_purchase_storekit_objc/FLTMethodChannelProtocol.h
Outdated
Show resolved
Hide resolved
loic-sharma
approved these changes
Jan 27, 2025
Member
loic-sharma
left a comment
There was a problem hiding this comment.
Swift Package Manager changes look good to me! Thank you for all the hard work, this is an excellent contribution 🥳
LouiseHsu
approved these changes
Jan 27, 2025
Contributor
LouiseHsu
left a comment
There was a problem hiding this comment.
Looks good to me too! I checked out your branch and everything functions correctly, thank you so much for doing this!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 5, 2025
flutter/packages@02c6fef...e6ce02c 2025-02-05 [email protected] [vector_graphics] Allow transition between placeholder and loaded image to have an animation (flutter/packages#8195) 2025-02-04 [email protected] [flutter_markdown] Make custom table column alignments work when text wraps (flutter/packages#8340) 2025-02-04 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMAAdPodInfo` (flutter/packages#8429) 2025-02-03 [email protected] [pigeon] reorg generator files (flutter/packages#8532) 2025-02-03 [email protected] [pigeon] [swift] Fix `PigeonError` sendability conformance in Swift 6 (flutter/packages#8302) 2025-02-03 [email protected] Roll Flutter from b007899 to 8e2a6fc (61 revisions) (flutter/packages#8556) 2025-02-03 [email protected] [google_maps_flutter] Support for Ground Overlay - platform interface (flutter/packages#8518) 2025-01-31 [email protected] [tool] Add --xcode-warnings-exceptions flag (flutter/packages#8524) 2025-01-31 [email protected] [tool] Ensure that injected dependency overrides are sorted (flutter/packages#8542) 2025-01-31 [email protected] [vector_graphics] Revert leak tracker change (flutter/packages#8544) 2025-01-31 [email protected] [shared_preferences_tool] Loosen vm_service constraint to allow for 15 (flutter/packages#8539) 2025-01-31 [email protected] [in_app_purchase] Activate leak testing for android (flutter/packages#8369) 2025-01-31 [email protected] [flutter_markdown] Allow tables to be scrollable with IntrinsicColumnWidth (flutter/packages#8526) 2025-01-30 [email protected] Update CODEOWNERS for pkg:animations (flutter/packages#8534) 2025-01-30 [email protected] Roll Flutter from c1ffaa9 to b007899 (43 revisions) (flutter/packages#8527) 2025-01-30 [email protected] [video_player_web] Adjust Web implementation to the new platform interface (flutter/packages#8528) 2025-01-30 [email protected] [shared_preferences] Exposed SharedPreferencesOptions. (flutter/packages#8530) 2025-01-29 [email protected] Re-land [shared_preferences] Add shared preferences devtool (flutter/packages#8531) 2025-01-29 [email protected] [in_app_purchase_storekit] Add Swift Package Manager compatibility (flutter/packages#8469) 2025-01-29 [email protected] Revert "Re-land [shared_preferences] Add shared preferences devtool" (flutter/packages#8529) 2025-01-29 [email protected] [go_router_builder] Fixes trailing `?` by comparing iterables (flutter/packages#8521) 2025-01-29 [email protected] [tool] Refactor args of strings or YAML file lists (flutter/packages#8513) 2025-01-28 [email protected] [go_router] Add missing await keyword to onTap callback in the code example in `navigation.md` (flutter/packages#8343) 2025-01-28 [email protected] Re-land [shared_preferences] Add shared preferences devtool (flutter/packages#8519) 2025-01-28 [email protected] [vector_graphics] Fix memory leaks and activate leak testing [prod-leak-fix] (flutter/packages#8373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…lutter#8469) Makes `in_app_purchase_storekit` available as a Swift Package to Flutter Closes [#146905](flutter/flutter#146905)
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…lutter#8469) Makes `in_app_purchase_storekit` available as a Swift Package to Flutter Closes [#146905](flutter/flutter#146905)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
in_app_purchase_storekitavailable as a Swift Package to FlutterCloses #146905
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.