This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP] [skwasm] Fix platform view occlusion logic.#54871
Merged
auto-submit[bot] merged 3 commits intoflutter:flutter-3.24-candidate.0from Sep 10, 2024
Merged
Conversation
The occlusion rectangle for platform views was going through this `inverseMapRect` code path, which actually was giving us the wrong results. The operations should just be doing the normal transformation on the rectangles to get the right result. It actually turns out we don't need the inverse mapping function, so I removed it, and I renamed the somewhat confusingly named `cullRect` function to `mapRect` which I think makes a bit more sense. This should resolve flutter/flutter#152139
eyebrowsoffire
approved these changes
Aug 29, 2024
Contributor
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Cherry pick looks good to me! Thanks!
eyebrowsoffire
suggested changes
Aug 29, 2024
Contributor
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Looks like CI is failing, I'm guessing some there are some test changes that didn't make it over in the CP for some reason?
Rexios80
commented
Aug 29, 2024
Member
Author
|
Also I did notice that there is a |
eyebrowsoffire
approved these changes
Sep 5, 2024
Contributor
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Looks good! I'm not 100% sure about which branch should be targeted, I'll let the release team handle that particular question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #54061