This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP] [skwasm] Fix platform view placement.#54870
Merged
auto-submit[bot] merged 5 commits intoflutter:flutter-3.24-candidate.0from Sep 11, 2024
Merged
Conversation
Previously, each platform view contained styling/placement information from the entire stack of the layer builder. This caused issues when using `addRetained`, since it would contain stale styling/placement information from its old parent layers. I have changed it so that platform views only contain local styling information, and that styling is combined with the parent only when the layers are merged.
Member
Author
|
@eyebrowsoffire Any thoughts on this one? Also there was just a release. Does that mean the target branch should change on these PRs? |
eyebrowsoffire
approved these changes
Sep 5, 2024
Contributor
eyebrowsoffire
left a comment
There was a problem hiding this comment.
LGTM! (Again, not sure about the release branch stuff, hopefully someone on the release team will clarify if that needs to be changed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #53845