PCG serialization, rapidcheck, dtgen, and shape inference#1394
PCG serialization, rapidcheck, dtgen, and shape inference#1394lockshaw merged 46 commits intoflexflow:repo-refactorfrom
Conversation
* enable rapidchecks for op-attrs * added rc::checks * fix merge * fixed variant toml * revert proj.toml * removed additional import merged * constraint for ff_dim * lock flake --------- Co-authored-by: Rae Wong <raewong@sapling2.stanford.edu>
wmdi
left a comment
There was a problem hiding this comment.
Reviewed 2 of 82 files at r4, all commit messages.
Reviewable status: 633 of 713 files reviewed, 1 unresolved discussion (waiting on @lockshaw and @reyna-abhyankar)
lib/op-attrs/include/op-attrs/parallel_tensor_shape.h line 15 at r1 (raw file):
Previously, lockshaw (Colin Unger) wrote…
I think "sharding" is actually the right name for the operation, I probably used it incorrectly above (maybe "instances" would be better for sharding+replicas? not sure).
CombineParallelDimandPartitionParallelDimboth sound more like actions than a type of dim (asCombineandPartitionare both verbs, andCombineisn't a great name anyway), andConcatParallelDimis even more confusing as we have a non-parallel concat operator. I agree there's room for improved naming, but at least until I get around to renaming a bunch of other stuff to be less ambiguous I think "shard" is the best I can think of? (the main contender I can think of isPartitionParallelDim, but I'm not sure that's any better thanShardParallelDim, and I'm not sure we want to explicitly tie the concept of their being multiple disjoint shards exactly to thePartitionoperator). @reyna-abhyankar do you have any thoughts on this?
I think it is fine to keep it and find a better name later.
wmdi
left a comment
There was a problem hiding this comment.
Reviewed 80 of 82 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @reyna-abhyankar)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## repo-refactor #1394 +/- ##
==================================================
- Coverage 41.32% 18.81% -22.52%
==================================================
Files 181 263 +82
Lines 5265 12631 +7366
Branches 271 0 -271
==================================================
+ Hits 2176 2377 +201
- Misses 3089 10254 +7165
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lockshaw
left a comment
There was a problem hiding this comment.
Dismissed @wmdi from a discussion.
Reviewable status: 700 of 736 files reviewed, all discussions resolved (waiting on @wmdi)
Description of changes:
dtgenAddReLULinearConv2DBatchMMEmbeddingRepartitionCombineReplicateReductionsubstitutionsPCG,ComputationGraph, etc. do be serializable and based on newDataflowGraphabstractionArbitraryinstances for many types, primarily through moving many types over todtgenNote: this PR temporarily breaks
substitutions, which will be moved to a follow-up PR to prevent this PR from growing too largeRelated Issues:
Supersedes #988
Linked Issues:
ModelCompilationResultserialization and deserialization code #919Issues closed by this PR:
ParallelDim#1276This change is