Adding to unity substitution set#1594
Closed
victorli2002 wants to merge 96 commits intoflexflow:masterfrom
Closed
Conversation
…ution-builder' into victor-substitution-builder
victorli2002
commented
Feb 7, 2025
Collaborator
Author
victorli2002
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 437 files reviewed, 1 unresolved discussion
lib/substitutions/test/src/substitutions/unity_substitution_set.cc line 34 at r1 (raw file):
TEST_CASE("create_replicate_linear_combine") { SUBCASE("use_bias = false") {
Having trouble getting this test to work, not sure where needs to be fixed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1594 +/- ##
==============================
==============================
🚀 New features to boost your workflow:
|
added 6 commits
February 21, 2025 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filling out unity_substitution_set with tests
This change is