Merged
Conversation
lockshaw
requested changes
May 14, 2024
Owner
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 103 of 103 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yingyee0111)
lib/op-attrs/include/op-attrs/operator_attrs.h line 34 at r1 (raw file):
#include "ops/topk.h" #include "ops/transpose.h" #include "utils/record_formatter.h"
Why?
lib/op-attrs/src/op-attrs/ff_dim.dtg.cc line 59 at r1 (raw file):
namespace rc { Gen<FlexFlow::ff_dim_t> Arbitrary<FlexFlow::ff_dim_t>::arbitrary() { return gen::construct<FlexFlow::ff_dim_t>(gen::arbitrary<int>());
Should probably be constrained by MAX_TENSOR_DIM
lockshaw
approved these changes
May 24, 2024
Owner
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 81 of 81 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yingyee0111)
lib/op-attrs/src/op-attrs/computation_graph_op_attrs.dtg.cc line 404 at r2 (raw file):
gen::cast<::FlexFlow::ComputationGraphOpAttrs>( gen::arbitrary<::FlexFlow::DropoutAttrs>()), gen::cast<::FlexFlow::ComputationGraphOpAttrs>(
Why cast instead of construct?
lockshaw
added a commit
that referenced
this pull request
Jun 4, 2024
) * Add initial lib/substitution-generator and bin/substitutions-to-dot * Format * Update proj version and add .proj.toml file to repo directly * Revert changes to flake.nix * Prototype implementation of dtgen * Refactor op-attrs to use dtgen * Format * More dtgen'ing * Re-pass tests * Simplify types in substitutions, more dtgen * Add new reduction dim shape inference for conv2d * Move conv2d input parsing into public headers * Remove incorrect not_implemented * Add pcg tests * Add initial test for pcg * Partial implementation of shape inference for linear * Fix rapidcheck (#8) * enable rapidchecks for op-attrs * added rc::checks * fix merge * fixed variant toml * revert proj.toml * removed additional import merged * constraint for ff_dim * lock flake --------- Co-authored-by: Rae Wong <raewong@sapling2.stanford.edu> * Attempt to hide dtgen-generated files from github diff * Fix header file name for dtgen in gitattributes * Update proj and format code * Add initial shape inference for BMM * Add half of shape inference for Attention * Finish initial shape inference for Attention * Enable op-attrs and pcg tests in CI * Add parallel shape inference for add and relu * Add parallel shape inference for embedding * Add shape inference for repartition, combine, replicate, and reduction * Include tests for reduction * Address wmdi comments * Fixup linear shape inference, add tests for linear * Fix tests * Format * Fix build errors * change lcov in ci to rm dtgen coverage * Remove dtgen from coverage * Temporarily disable substitutions build in CI * Format * Fix substitution-generator build and tests * Format * fix ci coverage attempt * second attempt * small fix * small fix --------- Co-authored-by: Rae Wong <33883582+yingyee0111@users.noreply.github.com> Co-authored-by: Rae Wong <raewong@sapling2.stanford.edu> Co-authored-by: Qinghan Chen <qinghanc@andrew.cmu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Enabled rapidcheck in opattrs
NOTES
Related Issues:
Linked Issues:
Issues closed by this PR:
Before merging:
This change is