Skip to content

Remove unused functions about finding the best ancestors in the call tree, whose usage was removed in #2435#4374

Merged
julienw merged 2 commits into
firefox-devtools:mainfrom
julienw:remove-unused-function
Dec 20, 2022
Merged

Remove unused functions about finding the best ancestors in the call tree, whose usage was removed in #2435#4374
julienw merged 2 commits into
firefox-devtools:mainfrom
julienw:remove-unused-function

Conversation

@julienw
Copy link
Copy Markdown
Contributor

@julienw julienw commented Dec 15, 2022

I found that this function is currently unused, and some of other functions were used only by that one. But they might be useful in the future possibly, see for example this comment from Greg. Happy to hear your thoughts about removing this.

I believe that our minifying plugin removes them in the bundle too.

@julienw julienw requested a review from canova December 15, 2022 16:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2022

Codecov Report

Base: 88.35% // Head: 88.55% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (9534bd8) compared to base (f3cfe76).
Patch has no changes to coverable lines.

❗ Current head 9534bd8 differs from pull request most recent head 9160978. Consider uploading reports for the commit 9160978 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4374      +/-   ##
==========================================
+ Coverage   88.35%   88.55%   +0.19%     
==========================================
  Files         282      282              
  Lines       25383    25311      -72     
  Branches     6830     6819      -11     
==========================================
- Hits        22428    22414      -14     
+ Misses       2742     2695      -47     
+ Partials      213      202      -11     
Impacted Files Coverage Δ
src/actions/profile-view.js 90.00% <ø> (+2.63%) ⬆️
src/profile-logic/profile-data.js 93.42% <ø> (+3.01%) ⬆️
src/profile-logic/marker-data.js 93.64% <0.00%> (-0.13%) ⬇️
src/selectors/publish.js 96.87% <0.00%> (ø)
src/components/tooltip/Marker.js 98.44% <0.00%> (ø)
src/profile-logic/marker-schema.js 89.18% <0.00%> (ø)
src/components/marker-table/index.js 88.40% <0.00%> (ø)
src/components/tooltip/TrackPower.js 100.00% <0.00%> (ø)
src/profile-logic/sanitize.js 96.55% <0.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think I'm fine removing it since it will be in our git history. But it will be harder to find of couse since we need to remember that it's in our git history when we need it.

@julienw julienw changed the title Remove unused function, whose usage was removed in #2435 Remove unused functions around finding the best ancestors in the call tree, whose usage was removed in #2435 Dec 19, 2022
@julienw julienw changed the title Remove unused functions around finding the best ancestors in the call tree, whose usage was removed in #2435 Remove unused functions about finding the best ancestors in the call tree, whose usage was removed in #2435 Dec 19, 2022
@julienw
Copy link
Copy Markdown
Contributor Author

julienw commented Dec 20, 2022

Thanks! I changed the title of the PR so that hopefully it should be easier to find if we need it in the future.

@julienw julienw merged commit 5acabe1 into firefox-devtools:main Dec 20, 2022
@julienw julienw mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants