Remove unused functions about finding the best ancestors in the call tree, whose usage was removed in #2435#4374
Conversation
Codecov ReportBase: 88.35% // Head: 88.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4374 +/- ##
==========================================
+ Coverage 88.35% 88.55% +0.19%
==========================================
Files 282 282
Lines 25383 25311 -72
Branches 6830 6819 -11
==========================================
- Hits 22428 22414 -14
+ Misses 2742 2695 -47
+ Partials 213 202 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
canova
left a comment
There was a problem hiding this comment.
Hm, I think I'm fine removing it since it will be in our git history. But it will be harder to find of couse since we need to remember that it's in our git history when we need it.
|
Thanks! I changed the title of the PR so that hopefully it should be easier to find if we need it in the future. |
I found that this function is currently unused, and some of other functions were used only by that one. But they might be useful in the future possibly, see for example this comment from Greg. Happy to hear your thoughts about removing this.
I believe that our minifying plugin removes them in the bundle too.