Skip to content

Revert timeline activity graph CallNode selection#2435

Merged
gregtatum merged 2 commits into
firefox-devtools:masterfrom
daniel-234:revert-timeline-activity-graph-callnode-selection
Mar 5, 2020
Merged

Revert timeline activity graph CallNode selection#2435
gregtatum merged 2 commits into
firefox-devtools:masterfrom
daniel-234:revert-timeline-activity-graph-callnode-selection

Conversation

@daniel-234
Copy link
Copy Markdown
Contributor

Fixes #2404

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2020

Codecov Report

Merging #2435 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
- Coverage   86.41%   86.07%   -0.35%     
==========================================
  Files         207      207              
  Lines       15669    15665       -4     
  Branches     3966     3963       -3     
==========================================
- Hits        13541    13483      -58     
- Misses       1949     1991      +42     
- Partials      179      191      +12
Impacted Files Coverage Δ
src/components/timeline/TrackThread.js 97.43% <ø> (-0.24%) ⬇️
src/actions/profile-view.js 84.52% <0%> (-5.45%) ⬇️
src/profile-logic/profile-data.js 90.11% <0%> (-4.05%) ⬇️
src/reducers/profile-view.js 96.2% <0%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4618cc...85f9010. Read the comment docs.

@julienw julienw requested a review from gregtatum March 4, 2020 15:50
Copy link
Copy Markdown
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this change looks great!

@gregtatum gregtatum merged commit 004019e into firefox-devtools:master Mar 5, 2020
@daniel-234 daniel-234 deleted the revert-timeline-activity-graph-callnode-selection branch March 6, 2020 08:16
julienw added a commit to julienw/perf.html that referenced this pull request Dec 15, 2022
julienw added a commit that referenced this pull request Dec 20, 2022
…ode" in the call tree (PR #4374)

The last usage for this function was removed in the PR #2435.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call node selection behavior makes it hard to step through samples while also displaying categories

2 participants