Fix slow open rocksdb cloud when DB is large#200
Conversation
WalkthroughUpdates the Eloq store_handler Git submodule reference from commit ca901f6 to 7ca9d31. No source code, API, or control-flow changes; only repository metadata updated. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/mongo/db/modules/eloq/store_handler (1)
1-1: CI/release hygiene for submodules
- Ensure CI uses: git submodule sync --recursive && git submodule update --init --recursive.
- Consider referencing a signed tag if available for supply‑chain clarity.
- Add a brief PR note/changelog referencing the upstream commit(s) that address the slow RocksDB Cloud open on large DBs, plus a perf sanity check result.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/mongo/db/modules/eloq/store_handler(1 hunks)
🔇 Additional comments (1)
src/mongo/db/modules/eloq/store_handler (1)
1-1: Submodule bump to store_handler — verification incompleteOld -> New: ca901f647598f6d2ee19dd6f09dbfa16637deec1 -> 7ca9d319d3d24a7185c3594b4af2c9ed74093774; Submodule URL: https://github.com/eloqdata/store_handler.git. Automated commit-range inspection failed with "/bin/bash: -c: line 24: conditional binary operator expected" — re-run verification or manually confirm that 7ca9d319... is reachable upstream and that the commit range includes the RocksDB Cloud "open" fix.
Summary by CodeRabbit