Fix the incorrect initialization of mv_base_idx_vec_ in constuctor of txservice::HashPartitionDataSyncScanCc

[lzxddz]

PR:
eloqdata/tx_service#164
eloqdata/store_handler#110

Summary by CodeRabbit

• Chores
  • Updated internal dependencies with no functional changes or impact to user-facing features.

[coderabbitai]

Walkthrough

Two eloq submodule references were updated: src/mongo/db/modules/eloq/store_handler advanced from a3fdbbc866c9... to cd88ee6ec2a4..., and src/mongo/db/modules/eloq/tx_service advanced from b823488d3c6e... to c689ba46cd96.... No functional code changes detected in the main repository.

Changes

Cohort / File(s)	Summary
Eloq submodule pointers src/mongo/db/modules/eloq/store_handler, src/mongo/db/modules/eloq/tx_service	Submodule commit references updated (store_handler: a3fdbbc... → cd88ee6e...; tx_service: b823488... → c689ba46...). No changes to exported/public APIs or functional code in main repo.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Update submodules #227 — identical submodule reference updates for both store_handler and tx_service.
• Fix slow open rocksdb cloud when DB is large #200 — advances the same store_handler submodule pointer.
• update submodules #206 — advances the same tx_service submodule pointer.

Suggested reviewers

• xiexiaoy
• liunyl

Poem

🐰 Submodules hop to a newer cue,
Two pointers nudge, the tree breathes anew,
No code rewrites, just hashes in line,
A tiny bump — the repo’s fine! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title describes fixing the incorrect initialization of mv_base_idx_vec_ in the constructor of txservice::HashPartitionDataSyncScanCc. The PR objectives confirm this is the stated purpose of the PR. The changeset updates submodule references for store_handler and tx_service that contain the implementation of this fix. The title accurately represents what the PR aims to accomplish and is directly related to the functional change being integrated through the submodule updates. The title is concise, specific, and clearly communicates the primary intent of the PR.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc9163f and df467fa.

📒 Files selected for processing (2)

• src/mongo/db/modules/eloq/store_handler (1 hunks)
• src/mongo/db/modules/eloq/tx_service (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/mongo/db/modules/eloq/store_handler

🚧 Files skipped from review as they are similar to previous changes (1)

• src/mongo/db/modules/eloq/tx_service

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/mongo/db/modules/eloq/store_handler (1)

1-1: Optional: reference an annotated tag or upstream PR in the description.

If available, point the submodule to an annotated tag (or add the upstream commit/PR link) for traceability and easier backports.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ed174d and fc9163f.

📒 Files selected for processing (2)

• src/mongo/db/modules/eloq/store_handler (1 hunks)
• src/mongo/db/modules/eloq/tx_service (1 hunks)

🔇 Additional comments (2)

src/mongo/db/modules/eloq/tx_service (1)

1-1: Submodule bump verified—contains the intended mv_base_idx_vec_ fix with no breaking changes.

The new commit 5bb8a128 includes the targeted fix: line 3393 of include/cc/cc_request.h changes mv_base_idx_vec_.resize(scan_batch_size) to mv_base_idx_vec_.reserve(scan_batch_size) in the HashPartitionDataSyncScanCc constructor. Only this file was modified; no unintended API or ABI changes detected.

src/mongo/db/modules/eloq/store_handler (1)

1-1: Verified: tx_service fix is included and store_handler bump is valid.

The tx_service submodule now includes commit 5bb8a12 fix HashPartitionDataSyncScanCc, which addresses the PR objective. The grep confirms both HashPartitionDataSyncScanCc and mv_base_idx_vec_ are present in the updated tx_service (including the constructor reserve at line 3393 and member declaration at line 3588). The store_handler bump is independent—it contains unrelated bug fixes (logging, max_open_files, drop table request) and does not need to reference tx_service symbols. Both submodule bumps are valid.