Skip to content

Don't save deleted records into data_store if mvcc is not enabled on RangePartition#231

Merged
lzxddz merged 1 commit intoeloqdata:mainfrom
lzxddz:update-putall
Oct 11, 2025
Merged

Don't save deleted records into data_store if mvcc is not enabled on RangePartition#231
lzxddz merged 1 commit intoeloqdata:mainfrom
lzxddz:update-putall

Conversation

@lzxddz
Copy link
Copy Markdown
Collaborator

@lzxddz lzxddz commented Oct 11, 2025

Summary by CodeRabbit

  • Chores

    • Updated an internal module reference to a newer revision; no functional or API changes.
  • No User-Facing Changes

    • App behavior, features, and interfaces remain unchanged.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The submodule at src/mongo/db/modules/eloq/store_handler was updated to point from commit db720400d195c7164c386e13ca2811fa668123de to b3e65901f34d6580617fea9ce89adec0426f4aae. No source files or public APIs in this repository were modified.

Changes

Cohort / File(s) Summary
Submodule pointer update
src/mongo/db/modules/eloq/store_handler
Updated submodule commit from db720400d195c7164c386e13ca2811fa668123de to b3e65901f34d6580617fea9ce89adec0426f4aae.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • liunyl

Poem

I hop and nudge a tiny hash,
a quiet change, a gentle dash.
No files swapped, no lines to bind,
just a pointer to the next find.
Carrots queued—commit refreshed! 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title describes a functional change to skip saving deleted records when MVCC is disabled, but the diff only updates a submodule commit pointer without any code or API modifications, so the title does not match the actual changes. Please update the pull request title to accurately reflect the submodule reference update (for example “Update eloq store_handler submodule reference to cea8902e18fbe6672461f437728d6272a399946b”) or include the code changes that correspond to the described behavior.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0682a9 and b800758.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/store_handler (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lzxddz lzxddz merged commit 3a02751 into eloqdata:main Oct 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants