Use libucontext in 2.7 to fix alpine based builds on arm32v6/7 and s390x#364
Merged
tianon merged 1 commit intodocker-library:masterfrom Oct 26, 2021
Merged
Use libucontext in 2.7 to fix alpine based builds on arm32v6/7 and s390x#364tianon merged 1 commit intodocker-library:masterfrom
tianon merged 1 commit intodocker-library:masterfrom
Conversation
yosifkit
commented
Oct 25, 2021
| libffi-dev \ | ||
| libxml2-dev \ | ||
| libxslt-dev \ | ||
| libucontext-dev \ |
Member
Author
There was a problem hiding this comment.
Harmless without LIBS also being set.
checking for getcontext... no
checking for setcontext... no3.0 and 2.6 build fine without the LIBS variable, so I figured it is likely safer to not include it for them.
Member
|
I've updated #360 to hopefully put this sha256sum issue to rest. |
Member
|
Now that #360 is in, can we rebase? 🙏 😇 |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 26, 2021
Changes: - docker-library/ruby@4d6eafa: Merge pull request docker-library/ruby#364 from infosiftr/arches - docker-library/ruby@53a12c2: Use libucontext in 2.7 to fix alpine based builds on arm32v6/7 and s390x - docker-library/ruby@2caaf19: Merge pull request docker-library/ruby#360 from docker-library/revert-358-confused - docker-library/ruby@659f4ab: Remove sha256sum from GitHub patch file
This was referenced Oct 27, 2021
Member
|
Heads up for folks who haven't seen it yet -- this broke things (#365), and there's a new patch coming Soon. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alpine also uses
ucontexton all arches for their Ruby 2.7.