fix: MN update notifications had old_list/new_list swapped

[UdjinM6]

Issue being fixed or feature implemented

• UI: Masternode list tab displayed state at block X-1 while node was at block X
• Net: mnauth disconnect handling could miss removals, keeping removed masternode peers connected longer than intended

Noticed while reviewing #7146

What was done?

How Has This Been Tested?

Run qt, open masternode list tab, sort by last paid (desc). Open Info dialog to see block height, wait for another block after full sync and compare.

Breaking Changes

n/a

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[PastaPastaPasta]

utACK 5e5aaec

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

The changes modify two aggregate initializations in src/evo/deterministicmns.cpp by switching from positional initialization syntax to designated-field initialization. Specifically, the MNListUpdates struct initialization in ProcessBlock and UndoBlock now explicitly names each field (old_list, new_list, diff) rather than relying on implicit field ordering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: swapping of old_list and new_list fields in MNListUpdates initialization, which directly addresses the UI and network issues mentioned in the PR objectives.
Description check	✅ Passed	The description clearly relates to the changeset by explaining the issues being fixed (UI displaying wrong block state, mnauth disconnect handling) and how to test the fix, though the 'What was done?' section is empty.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[kwvg]

utACK 5e5aaec