Skip to content

fix(qt): move labelError styling from proposalcreate.ui into general.css#7145

Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom
UdjinM6:fix_propcrecss
Feb 17, 2026
Merged

fix(qt): move labelError styling from proposalcreate.ui into general.css#7145
PastaPastaPasta merged 1 commit intodashpay:developfrom
UdjinM6:fix_propcrecss

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 15, 2026

Issue being fixed or feature implemented

labelError styling is in the wrong place, it's a translatable string (missed notr="true") and... it is not actually working at all 🤷‍♂️

develop this PR
Screenshot 2026-02-14 at 00 27 44 Screenshot 2026-02-14 at 00 29 24

Discovered thanks to a broken translation found by @coderabbitai #7141 (comment)

What was done?

Move labelError styling from proposalcreate.ui into general.css. Will be dropped from *.ts files in some future Translations PR.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@github-actions
Copy link

This pull request has conflicts, please rebase.

@github-actions
Copy link

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026

Walkthrough

This change relocates the margin-left: 8px styling for the labelError element from an inline styleSheet property in the UI form file to an external CSS stylesheet. The styling definition is moved from src/qt/forms/proposalcreate.ui to a new ProposalCreate section in src/qt/res/css/general.css, consolidating style definitions in a dedicated stylesheet rather than embedding them within the UI layout file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: moving labelError styling from proposalcreate.ui to general.css, which matches the changeset exactly.
Description check ✅ Passed The description is directly related to the changeset, explaining the issue, the solution, and providing visual evidence of the problem being fixed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@UdjinM6 UdjinM6 added this to the 23.1.1 milestone Feb 15, 2026
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK bc779c6

@PastaPastaPasta PastaPastaPasta merged commit 6c7a8df into dashpay:develop Feb 17, 2026
40 of 43 checks passed
thepastaclaw pushed a commit to thepastaclaw/dash that referenced this pull request Feb 27, 2026
…ate.ui into general.css

bc779c6 fix(qt): move labelError styling from proposalcreate.ui into general.css (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  `labelError` styling is in the wrong place, it's a translatable string (missed `notr="true"`) and... it is not actually working at all 🤷‍♂️
  |develop | this PR|
  |-|-|
  | <img width="972" height="520" alt="Screenshot 2026-02-14 at 00 27 44" src="https://github.com/user-attachments/assets/896a9245-ff1e-45cf-902a-93fe6a4785b1" /> | <img width="972" height="520" alt="Screenshot 2026-02-14 at 00 29 24" src="https://github.com/user-attachments/assets/2fffb0c4-b8ed-49d4-a554-3f78ee382488" /> |

  Discovered thanks to a broken translation found by @coderabbitai dashpay#7141 (comment)

  ## What was done?
  Move `labelError` styling from `proposalcreate.ui` into `general.css`. Will be dropped from `*.ts` files in some future Translations PR.

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  kwvg:
    utACK bc779c6

Tree-SHA512: 08724dd5506723ba00cad50a9643b6b8a143894df2d53ab6f193d11e84880757d9c82c4aa9a13fe25cb5f2953ffcde590f6d7630bdae8d436b739c1f6fa8f647
PastaPastaPasta added a commit that referenced this pull request Mar 3, 2026
00f590d Merge #7180: qt: add Tahoe styled icons for macOS, runtime styling for each network type, update bundle icon, add mask-based tray icon, generation scripts (pasta)
60dda51 Merge #7176: perf: do linear lookup instead building 2 heavy Hash-Maps (pasta)
df1ca87 Merge #7159: feat(qt): UI refresh (5/n, add proposal information widget to information, donut chart for proposal allocation) (pasta)
9061ad0 Merge #7118: feat(qt): UI refresh (4/n, introduce distinct widgets for Dash-specific reporting in debug window) (pasta)
64cc4f2 Merge #7160: feat(interfaces): consolidate masternode counts into one struct, expose chainlock, instantsend, credit pool, quorum statistics (pasta)
5d28a69 Merge #7157: fix(qt): prevent banned masternodes from returning status=0 (pasta)
e0b7386 Merge #7146: feat(qt): introduce framework for sourcing and applying data, use for `{Masternode,Proposal}List`s (pasta)
8fd53cd Merge #7144: feat(qt): add support for reporting `OP_RETURN` payloads as Data Transactions (pasta)
cc6f0bb Merge #7154: fix: MN update notifications had old_list/new_list swapped (pasta)
33f0138 Merge #7145: fix(qt): move labelError styling from proposalcreate.ui into general.css (pasta)
1bdbde6 Merge #7148: feat(qt): persist filter preferences in masternode list (pasta)
96bb601 Merge #7147: fix(qt): prevent overview page font double scaling, recalculate minimum width correctly, `SERVICE` and `STATUS` sorting, fix common types filtering (pasta)

Pull request description:

  ## Backport PRs for v23.1.1

  Cherry-picks the following 12 PRs (labeled `backport-candidate-23.1.x`) from `develop` onto `v23.1.x`, in merge order:

  | PR | Title |
  |---|---|
  | #7147 | fix(qt): prevent overview page font double scaling, recalculate minimum width correctly, `SERVICE` and `STATUS` sorting, fix common types filtering |
  | #7148 | feat(qt): persist filter preferences in masternode list |
  | #7145 | fix(qt): move labelError styling from proposalcreate.ui into general.css |
  | #7154 | fix: MN update notifications had old_list/new_list swapped |
  | #7144 | feat(qt): add support for reporting `OP_RETURN` payloads as Data Transactions |
  | #7146 | feat(qt): introduce framework for sourcing and applying data, use for `{Masternode,Proposal}List`s |
  | #7157 | fix(qt): prevent banned masternodes from returning status=0 |
  | #7160 | feat(interfaces): consolidate masternode counts into one struct, expose chainlock, instantsend, credit pool, quorum statistics |
  | #7118 | feat(qt): UI refresh (4/n, introduce distinct widgets for Dash-specific reporting in debug window) |
  | #7159 | feat(qt): UI refresh (5/n, add proposal information widget to information, donut chart for proposal allocation) |
  | #7176 | perf: do linear lookup instead building 2 heavy Hash-Maps |
  | #7180 | qt: add Tahoe styled icons for macOS, runtime styling for each network type, update bundle icon, add mask-based tray icon, generation scripts |

  All 12 cherry-picked cleanly (no conflicts).

  ## Notes
  - Used `git cherry-pick -m 1 <merge-sha>` for each (all were merge commits on develop)
  - Applied in chronological merge order to respect dependency chains
  - Version bump and release notes are separate steps per the release process

ACKs for top commit:
  kwvg:
    utACK 00f590d
  UdjinM6:
    utACK 00f590d

Tree-SHA512: 90d2a0660db8daa69b3e3b33a8a790fb0ea7d9a04656a2e27955575e76b6f4c9a379c435ef1c573ef6669c36cb6e205ba9701716d3dc303b01f19c719516b6d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants