fix(qt): prevent overview page font double scaling, recalculate minimum width correctly, SERVICE and STATUS sorting, fix common types filtering

[kwvg]

Additional Information

Fix	develop (06e761e)	This PR (ec8ee9c)
Correct common types filter behaviour to restore exclusion of CoinJoin mixing transactions
Enforce minimum width correctly (and prevent double scaling, look at "Recent transactions" font size)
Sorting by age (oldest active node)	Does not work
Sorting by service (IP address)	Does not work

Breaking Changes

None expected.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

• feat(qt): add support for reporting OP_RETURN payloads as Data Transactions #7144 - feat(qt): add support for reporting OP_RETURN payloads as Data Transactions

Please coordinate with the authors of these PRs to avoid merge conflicts.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

Changes touch Qt UI and models: masternode status values now use signed semantics (positive = banned time, negative = active time) and the masternode proxy model gains a custom lessThan to lexicographically compare SERVICE byte arrays; TransactionFilterProxy type-bit logic is converted to constexpr with a new EXCLUDED_TYPES mask and COMMON_TYPES updated; overview page uses a compile-time default font size and no longer excludes DustReceive transactions; BitcoinGUI now calls updateWidth() when toggling wallet actions; a forward declaration changed from class NodeContext; to struct NodeContext; in dummywallet.cpp.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 41.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Merge Conflict Detection	⚠️ Warning	❌ Merge conflicts detected (99 files): ⚔️ ci/dash/lint-tidy.sh (content) ⚔️ ci/test/04_install.sh (content) ⚔️ doc/descriptors.md (content) ⚔️ src/Makefile.am (content) ⚔️ src/active/context.cpp (content) ⚔️ src/active/context.h (content) ⚔️ src/bench/addrman.cpp (content) ⚔️ src/bench/base58.cpp (content) ⚔️ src/bench/bech32.cpp (content) ⚔️ src/bench/bench.h (content) ⚔️ src/bench/bip324_ecdh.cpp (content) ⚔️ src/bench/block_assemble.cpp (content) ⚔️ src/bench/bls.cpp (content) ⚔️ src/bench/bls_dkg.cpp (content) ⚔️ src/bench/bls_pubkey_agg.cpp (content) ⚔️ src/bench/ccoins_caching.cpp (content) ⚔️ src/bench/chacha20.cpp (content) ⚔️ src/bench/checkblock.cpp (content) ⚔️ src/bench/checkqueue.cpp (content) ⚔️ src/bench/coin_selection.cpp (content) ⚔️ src/bench/crypto_hash.cpp (content) ⚔️ src/bench/duplicate_inputs.cpp (content) ⚔️ src/bench/ecdsa.cpp (content) ⚔️ src/bench/ellswift.cpp (content) ⚔️ src/bench/examples.cpp (content) ⚔️ src/bench/gcs_filter.cpp (content) ⚔️ src/bench/hashpadding.cpp (content) ⚔️ src/bench/load_external.cpp (content) ⚔️ src/bench/lockedpool.cpp (content) ⚔️ src/bench/logging.cpp (content) ⚔️ src/bench/mempool_eviction.cpp (content) ⚔️ src/bench/mempool_stress.cpp (content) ⚔️ src/bench/merkle_root.cpp (content) ⚔️ src/bench/peer_eviction.cpp (content) ⚔️ src/bench/poly1305.cpp (content) ⚔️ src/bench/pool.cpp (content) ⚔️ src/bench/pow_hash.cpp (content) ⚔️ src/bench/prevector.cpp (content) ⚔️ src/bench/rollingbloom.cpp (content) ⚔️ src/bench/rpc_blockchain.cpp (content) ⚔️ src/bench/rpc_mempool.cpp (content) ⚔️ src/bench/strencodings.cpp (content) ⚔️ src/bench/string_cast.cpp (content) ⚔️ src/bench/util_time.cpp (content) ⚔️ src/bench/verify_script.cpp (content) ⚔️ src/bench/wallet_balance.cpp (content) ⚔️ src/bench/wallet_create.cpp (content) ⚔️ src/bench/wallet_loading.cpp (content) ⚔️ src/bitcoin-cli.cpp (content) ⚔️ src/bitcoin-wallet.cpp (content) ⚔️ src/bitcoind.cpp (content) ⚔️ src/dummywallet.cpp (content) ⚔️ src/init.cpp (content) ⚔️ src/interfaces/chain.h (content) ⚔️ src/llmq/ehf_signals.cpp (content) ⚔️ src/llmq/net_signing.cpp (content) ⚔️ src/llmq/net_signing.h (content) ⚔️ src/llmq/signing_shares.cpp (content) ⚔️ src/llmq/signing_shares.h (content) ⚔️ src/logging.cpp (content) ⚔️ src/logging.h (content) ⚔️ src/net_processing.cpp (content) ⚔️ src/net_processing.h (content) ⚔️ src/node/interfaces.cpp (content) ⚔️ src/qt/bitcoingui.cpp (content) ⚔️ src/qt/main.cpp (content) ⚔️ src/qt/masternodelist.cpp (content) ⚔️ src/qt/masternodelist.h (content) ⚔️ src/qt/masternodemodel.cpp (content) ⚔️ src/qt/overviewpage.cpp (content) ⚔️ src/qt/transactionfilterproxy.h (content) ⚔️ src/qt/transactionrecord.h (content) ⚔️ src/rpc/client.cpp (content) ⚔️ src/rpc/mempool.cpp (content) ⚔️ src/test/fuzz/process_message.cpp (content) ⚔️ src/test/fuzz/process_messages.cpp (content) ⚔️ src/test/fuzz/rpc.cpp (content) ⚔️ src/test/fuzz/string.cpp (content) ⚔️ src/test/util/net.h (content) ⚔️ src/test/util/setup_common.cpp (content) ⚔️ src/util/error.cpp (content) ⚔️ src/util/error.h (content) ⚔️ src/wallet/rpc/backup.cpp (content) ⚔️ src/wallet/rpc/transactions.cpp (content) ⚔️ src/wallet/rpc/util.cpp (content) ⚔️ src/wallet/rpc/wallet.cpp (content) ⚔️ src/wallet/scriptpubkeyman.cpp (content) ⚔️ src/wallet/scriptpubkeyman.h (content) ⚔️ src/wallet/wallet.cpp (content) ⚔️ test/functional/mempool_package_limits.py (content) ⚔️ test/functional/mempool_packages.py (content) ⚔️ test/functional/rpc_getblockfrompeer.py (content) ⚔️ test/functional/rpc_packages.py (content) ⚔️ test/functional/test_framework/util.py (content) ⚔️ test/functional/test_framework/wallet.py (content) ⚔️ test/functional/test_runner.py (content) ⚔️ test/functional/wallet_listsinceblock.py (content) ⚔️ test/functional/wallet_listtransactions.py (content) ⚔️ test/lint/lint-circular-dependencies.py (content) These conflicts must be resolved before merging into develop.	Resolve conflicts locally and push changes to this branch.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies multiple specific fixes including font scaling, width calculation, sorting for SERVICE and STATUS columns, and common types filtering, which all correspond to actual changes in the changeset.
Description check	✅ Passed	The description is directly related to the changeset, providing a comparison table showing fixes for common types filtering, font scaling, width enforcement, and sorting issues, with visual examples matching the implemented changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

⚔️ Resolve merge conflicts (beta)

• Auto-commit resolved conflicts to branch misc_fixes_p2
• Post resolved changes as copyable diffs in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/qt/masternodelist.cpp`:
- Around line 48-51: The current filter uses the EditRole integer (status_value)
from sourceModel()->data(idx, Qt::EditRole) and only hides nodes when
status_value > 0, which lets banned nodes with unknown/invalid poseBanHeight()
(that return 0) slip through; update the filter logic in masternodelist.cpp to
explicitly check the model entry's ban state instead of relying solely on the
EditRole integer: fetch the underlying entry (use the same lookup path you use
elsewhere in this file to map idx to the masternode entry), call
entry->isBanned() or inspect entry->poseBanHeight() (std::optional) and treat
unknown/invalid values as banned when m_current_height > 0, ensuring the "Hide
banned" branch hides any entry where entry->isBanned() is true or
poseBanHeight() indicates a ban rather than relying on status_value > 0.

🧹 Nitpick comments (1)

src/qt/transactionfilterproxy.h (1)

16-18: Consider a static_assert to guard against future enum overflow.

TransactionTypeToBit performs 1u << type, which is undefined behavior if type >= 32. Currently the max enum value (DustReceive) is 14, so it's safe. However, if someone adds more transaction types in the future, there's no compile-time safety net.

🛡️ Optional: add a compile-time guard

 /** Helper function to convert transaction type enum to bit field */
-constexpr quint32 TransactionTypeToBit(int type) { return 1u << type; }
+constexpr quint32 TransactionTypeToBit(int type) { return 1u << type; }
+static_assert(TransactionRecord::DustReceive < 32, "Transaction type enum exceeds quint32 bit capacity");

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

rg -n "poseBanHeight|pose_ban_height|PoSeBanHeight" --type=cpp --type=h -B2 -A2 | head -100

Repository: dashpay/dash

Length of output: 6749

---

🏁 Script executed:

# Find masternodemodel.cpp and examine the data() function around line 294
fd "masternodemodel.cpp" --type f

Repository: dashpay/dash

Length of output: 82

---

🏁 Script executed:

# Look for the STATUS column handling and ban logic
rg -n "STATUS.*EditRole|isBanned|ban_height" src/qt/ --type=cpp --type=h -B2 -A2 | head -150

Repository: dashpay/dash

Length of output: 4689

---

Banned nodes with unknown ban height will escape the "hide banned" filter.

When m_current_height > 0 and a banned node has no valid poseBanHeight() (nullopt or invalid value), the EditRole returns 0 at line 294. Since the filter checks status_value > 0 to hide banned nodes, a value of 0 won't be filtered out.

This is a real edge case: if the node state JSON lacks or has invalid PoSeBanHeight data, a banned node will display even when "Hide banned" is checked. While the node displays correctly with a banned icon, the filter logic should be consistent. Consider checking entry->isBanned() directly for the filter instead of relying on the EditRole value, or use >= 0 with a different sentinel for unknown ban times.

🤖 Prompt for AI Agents

In `@src/qt/masternodelist.cpp` around lines 48 - 51, The current filter uses the
EditRole integer (status_value) from sourceModel()->data(idx, Qt::EditRole) and
only hides nodes when status_value > 0, which lets banned nodes with
unknown/invalid poseBanHeight() (that return 0) slip through; update the filter
logic in masternodelist.cpp to explicitly check the model entry's ban state
instead of relying solely on the EditRole integer: fetch the underlying entry
(use the same lookup path you use elsewhere in this file to map idx to the
masternode entry), call entry->isBanned() or inspect entry->poseBanHeight()
(std::optional) and treat unknown/invalid values as banned when m_current_height
> 0, ensuring the "Hide banned" branch hides any entry where entry->isBanned()
is true or poseBanHeight() indicates a ban rather than relying on status_value >
0.

[UdjinM6]

light ACK ec8ee9c

[UdjinM6]

light ACK b568163