Skip to content

feat: add IntBoolCast for Entity#6348

Merged
kenjis merged 3 commits intocodeigniter4:4.3from
kenjis:feat-int-bool-cast
Aug 10, 2022
Merged

feat: add IntBoolCast for Entity#6348
kenjis merged 3 commits intocodeigniter4:4.3from
kenjis:feat-int-bool-cast

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Aug 6, 2022

Description

  • add IntBoolCast ('int-bool') for Entity

From codeigniter4/shield#339

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.3 labels Aug 6, 2022
@MGatner
Copy link
Copy Markdown
Member

MGatner commented Aug 6, 2022

@rmilecki #5944

@kenjis kenjis force-pushed the feat-int-bool-cast branch from 95072b8 to dd077aa Compare August 9, 2022 00:28
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Aug 9, 2022

Added the docs, and changed the handler name to int-bool.
Because json-arrayalready exists.

@kenjis kenjis requested a review from MGatner August 9, 2022 00:33
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 4649b0a into codeigniter4:4.3 Aug 10, 2022
@kenjis kenjis deleted the feat-int-bool-cast branch August 10, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that improve existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants