Merged
Conversation
$this->db->disableForeignKeyChecks() does not work on PostgreSQL.
pg_query(): Query failed: ERROR: column "active" is of type smallint but expression is of type boolean LINE 1: UPDATE "users" SET "active" = TRUE, "updated_at" = '2022-07-...
Postgre driver returns string as error code.
The DB column type is integer.
This was referenced Aug 5, 2022
MGatner
approved these changes
Aug 5, 2022
Member
MGatner
left a comment
There was a problem hiding this comment.
Looks good! What do you think about submitting IntBoolCast to the framework?
Member
|
It seems like all our tests are slower than Tachycardia wants; it might be good to increase the base rate so we can actually see which tests are particularly slow. |
Member
Author
|
It might be slow because of my Docker environment. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328
Fixes #327
IntBoolCastEntityclassCheckQueryReturnTrait