Skip to content

docs: allow boolean values in the model for PHPStan#9276

Merged
michalsn merged 2 commits intocodeigniter4:developfrom
ping-yee:9197_model_doc
Nov 17, 2024
Merged

docs: allow boolean values in the model for PHPStan#9276
michalsn merged 2 commits intocodeigniter4:developfrom
ping-yee:9197_model_doc

Conversation

@ping-yee
Copy link
Copy Markdown
Contributor

@ping-yee ping-yee commented Nov 13, 2024 •
edited
Loading

Description
fix #9197

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ping-yee ping-yee mentioned this pull request Nov 13, 2024
Closed
@neznaika0
Copy link
Copy Markdown
Contributor

neznaika0 commented Nov 13, 2024 •
edited
Loading

Ignored error pattern ...

requires removal from phpstan-baseline.php

@michalsn
Copy link
Copy Markdown
Member

michalsn commented Nov 14, 2024

@datamweb Will this solve the whole issue, or not?

@datamweb
Copy link
Copy Markdown
Contributor

datamweb commented Nov 15, 2024

@michalsn In my opinion, it’s better to write a unit test for this, as I can’t practically verify the issue for all drivers. However, this can be handled through GitHub Actions to ensure proper verification.

@michalsn
Copy link
Copy Markdown
Member

michalsn commented Nov 16, 2024

@datamweb I was under the impression that it was just a problem of setting allowed data types for PHPStan, which now treated booleans as an error.

We already have tests for boolean values: https://github.com/codeigniter4/CodeIgniter4/blob/develop/tests/system/Database/Live/UpdateTest.php#L363

datamweb
datamweb approved these changes Nov 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalsn, thank you so much for sharing the tests. 🙏 Also, the tests for PR #6348 are available as well.

@ping-yee , please edit the PR description and change See #9197 to fix #9197. Thanks! 😊

@michalsn michalsn changed the title docs: add the type to row_array in model. docs: allow boolean values in the model for PHPStan Nov 17, 2024
@michalsn michalsn linked an issue Nov 17, 2024 that may be closed by this pull request
Bug: [Model] Limitation in Boolean Support (true/false) in update()/save()/insert() #9197
Closed
@michalsn michalsn merged commit 42801e7 into codeigniter4:develop Nov 17, 2024
@ping-yee ping-yee deleted the 9197_model_doc branch November 28, 2024 13:02
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [Model] Limitation in Boolean Support (true/false) in update()/save()/insert()

5 participants

@ping-yee @neznaika0 @michalsn @datamweb @kenjis