Added not-found error message for hostname search#47
Added not-found error message for hostname search#47cmeissner merged 5 commits intocodeaffen:developfrom
Conversation
|
@mattiasa many thanks for submitting this pull request. May I ask you to provide a first test case for that exception. We would be very appreciated if you can do this. |
|
Sure, I can do that. I looked around among the tests and couldn't find anything that tested the actual server responses but I'll come up with something. |
|
Yeah unfortunately we don't have tests for all the exceptions yet. But this pr is a good starting point for that. |
cmeissner
left a comment
There was a problem hiding this comment.
The change isn't complex and it works for me.
Refactor exception.py to make `_NOT_FOUND_MESSAGES` available outside exception definition. Add test method for testing not found exceptions. Iterate over a list of dicts with test data. Add fixture for the new test case for not found exception.
|
@mattiasa I had some time to implement a first version for testing the |
* add changelog entry
|
Yea, thanks a lot for writing the tests. I didn't even get to a point where I could run the test suite before I had to put it aside for some other things. |
The following call raises a PHPyPAMException.
I would expect the library to raise PHPyPAMEntityNotFoundException instead. This PR fixes this by adding the error returned from phpipam to the expected list.