Skip to content

Added not-found error message for hostname search #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmeissner merged 5 commits into from
Sep 2, 2021
Merged

Added not-found error message for hostname search #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74d102c
Added not-found error message for address search
mattiasa Aug 31, 2021
d205b0c
Add test for PHPyPAMEntityNotFoundException
cmeissner Sep 2, 2021
43c5b72
Merge branch 'develop' into hostname_search_exception
cmeissner Sep 2, 2021
bf3b56c
fix some issues from codacy
cmeissner Sep 2, 2021
9e54c06
add missing data
cmeissner Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Changes

### Fixes
* fix #48 - raise PHPyPAMEntityNotFoundException if searching for non existing host

### Breaks

Expand Down
23 changes: 12 additions & 11 deletions phpypam/core/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@ class PHPyPAMException(Exception):
This exception is raised if anythings in :class:`phpypam.api` doesn't work out.
"""

_NOT_FOUND_MESSAGES = {
'No subnets found',
'Address not found',
'Vlan not found',
'No vrfs configured',
'No devices configured',
'No results (filter applied)',
'No objects found',
'Hostname not found'
}

def __init__(self, *args, code=None, message=None):
"""Generate PHPyPAMException.

Expand All @@ -24,17 +35,7 @@ def __init__(self, *args, code=None, message=None):
self._code = code
self._message = message

_NOT_FOUND_MESSAGES = {
'No subnets found',
'Address not found',
'Vlan not found',
'No vrfs configured',
'No devices configured',
'No results (filter applied)',
'No objects found',
}

if (self._code == 200 and self._message in _NOT_FOUND_MESSAGES) or self._code == 404:
if (self._code == 200 and self._message in self._NOT_FOUND_MESSAGES) or self._code == 404:
raise PHPyPAMEntityNotFoundException(self._message)
elif self._code == 500:
if self._message == 'Invalid username or password':
Expand Down
Loading