feat(desktop): always show channel section search/add buttons#856
Merged
Merged
Conversation
The channel section header's browse (search) and create (add) icon buttons were only revealed on hover/focus via SECTION_ACTION_VISIBILITY_CLASS on the whole action cluster. Make them persistently visible by dropping that class from the cluster wrapper and applying it only to the conditional "Mark all as read" button, which stays hover-revealed. The now-unused className prop on SectionHeaderActions is removed. Signed-off-by: Tyler Longwell <tlongwell@squareup.com>
wesbillman
approved these changes
Jun 4, 2026
tlongwell-block
pushed a commit
that referenced
this pull request
Jun 5, 2026
* origin/main: (39 commits) docs: add VISION_MESH.md — the compute-commons vision (#867) fix(desktop): simplify profile popover header (#853) fix(desktop): remove thread comment hover outline (#861) feat(desktop): always show channel section search/add buttons (#856) chore(release): release version 0.3.11 (#865) fix(mobile+desktop): cross-device read state sync + diagnostic logging (#843) feat(mobile): star channels (Slack-style favorites) (#863) feat: desktop-screenshot skill to stop agents uploading relay media to PRs (#862) feat(desktop): star channels (Slack-style favorites) (#860) fix(desktop): handle symlinked persona pack directories (#859) feat: channel muting for desktop and mobile (#838) feat(acp): default SPROUT_ACP_MEMORY to on (#854) fix(desktop): eliminate image-hover layout jump in messages (#813) chore(release): release version 0.3.10 (#849) fix(desktop): harden relay mesh connect p-tag (#834) fix(desktop): scroll activity panel to bottom on open (#848) Polish desktop profile menu interactions (#836) fix(desktop): outline thread hover targets (#845) fix(desktop): keep message actions hover-only (#844) fix(desktop): let inbox composer fill available width (#841) ...
tlongwell-block
pushed a commit
that referenced
this pull request
Jun 5, 2026
* origin/main: (39 commits) docs: add VISION_MESH.md — the compute-commons vision (#867) fix(desktop): simplify profile popover header (#853) fix(desktop): remove thread comment hover outline (#861) feat(desktop): always show channel section search/add buttons (#856) chore(release): release version 0.3.11 (#865) fix(mobile+desktop): cross-device read state sync + diagnostic logging (#843) feat(mobile): star channels (Slack-style favorites) (#863) feat: desktop-screenshot skill to stop agents uploading relay media to PRs (#862) feat(desktop): star channels (Slack-style favorites) (#860) fix(desktop): handle symlinked persona pack directories (#859) feat: channel muting for desktop and mobile (#838) feat(acp): default SPROUT_ACP_MEMORY to on (#854) fix(desktop): eliminate image-hover layout jump in messages (#813) chore(release): release version 0.3.10 (#849) fix(desktop): harden relay mesh connect p-tag (#834) fix(desktop): scroll activity panel to bottom on open (#848) Polish desktop profile menu interactions (#836) fix(desktop): outline thread hover targets (#845) fix(desktop): keep message actions hover-only (#844) fix(desktop): let inbox composer fill available width (#841) ... Signed-off-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co>
michaelneale
added a commit
that referenced
this pull request
Jun 6, 2026
* origin/main: chore(release): release version 0.3.12 (#886) Show hover cards for inline message emoji (#885) Fix monotonic read-state merges (#884) Refine sidebar behavior and borders (#869) fix(presence): clear on disconnect, fix heartbeat/TTL, drop broken REST path (#877) fix(cli): publish ephemeral events over WebSocket via sprout-ws-client (#876) docs(sprout-acp): add communication discipline rules to base prompt + deprecate --mention flag (#883) Polish thread summaries and reactions (#881) feat(cli): add emoji export and import subcommands (#882) Polish message row hover states (#880) Improve emoji naming and custom emoji UX (#878) docs: add ecosystem section to CONTRIBUTING.md, fix stale release info (#873) fix(relay): wire custom filter fields through HTTP bridge (#864) chore: deprecate sprout-mcp — fill CLI gaps, remove crate and all references (#850) Fix custom emoji status in profile popover (#874) fix(agent): gate handoff on provider token usage, not byte estimate (#821) docs: add VISION_MESH.md — the compute-commons vision (#867) fix(desktop): simplify profile popover header (#853) fix(desktop): remove thread comment hover outline (#861) feat(desktop): always show channel section search/add buttons (#856) # Conflicts: # crates/sprout-cli/src/client.rs # desktop/src/app/AppShell.tsx # justfile
tellaho
pushed a commit
that referenced
this pull request
Jun 8, 2026
Signed-off-by: Tyler Longwell <tlongwell@squareup.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the desktop left-hand sidebar, the channel section header's search (browse) and add (create) icon buttons were only revealed on hover/focus. This makes them always visible.
How
The two buttons live in
SectionHeaderActions(CustomChannelSection.tsx), alongside a conditional "Mark all as read" button. The whole cluster was gated bySECTION_ACTION_VISIBILITY_CLASS(opacity-0 … group-hover/sidebar-section:opacity-100).classNameprop onSectionHeaderActions(it was only ever passed the visibility class).Scope is precise: only the main Channels/Forums group header. The custom user-section management affordances (drag handle, rename, delete) keep their hover behavior — those aren't search/add and weren't in scope.
Test
tsc --noEmitcleanbiome checkclean on the filechannels.spec.ts,channel-browser.spec.ts,stream.spec.ts) clickbrowse-channels/ "Create a channel" directly; always-visible is a superset of the prior behavior, so no test relies on these being hover-hidden.+5 / -10, one file.