Skip to content

Polish thread summaries and reactions#881

Merged
klopez4212 merged 5 commits into
mainfrom
kennylopez-thread-reactions-polish
Jun 5, 2026
Merged

Polish thread summaries and reactions#881
klopez4212 merged 5 commits into
mainfrom
kennylopez-thread-reactions-polish

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Default
Screenshot 2026-06-05 at 20 01 26

Hover
Screenshot 2026-06-05 at 20 01 39

  • Tune reaction pills with a fixed 26px emoji-centering frame, more emoji/count spacing, and background-only default chips while keeping the active reacted state emphasized.
  • Adjust message row vertical rhythm by removing the negative name/body offset.
  • Polish the thread summary row under reacted messages with even 8px spacing around the reaction bar, 26px participant avatars, horizontal capsule breathing room, and the final left alignment tweak.

Validation

  • . ./bin/activate-hermit && cd desktop && pnpm exec biome check src/features/messages/ui/MessageReactions.tsx src/features/messages/ui/MessageRow.tsx src/features/messages/ui/MessageThreadSummaryRow.tsx

@klopez4212 klopez4212 marked this pull request as ready for review June 5, 2026 19:02
@klopez4212 klopez4212 requested a review from a team as a code owner June 5, 2026 19:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62df2ffe44

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/tests/e2e/custom-emoji.spec.ts
Comment thread desktop/tests/e2e/messaging.spec.ts
…ctions-polish

# Conflicts:
#	desktop/src/features/messages/ui/MessageReactions.tsx
…ctions-polish

# Conflicts:
#	desktop/tests/e2e/messaging.spec.ts
@klopez4212 klopez4212 merged commit 5c2476a into main Jun 5, 2026
15 checks passed
@klopez4212 klopez4212 deleted the kennylopez-thread-reactions-polish branch June 5, 2026 19:50
michaelneale added a commit that referenced this pull request Jun 6, 2026
* origin/main:
  chore(release): release version 0.3.12 (#886)
  Show hover cards for inline message emoji (#885)
  Fix monotonic read-state merges (#884)
  Refine sidebar behavior and borders (#869)
  fix(presence): clear on disconnect, fix heartbeat/TTL, drop broken REST path (#877)
  fix(cli): publish ephemeral events over WebSocket via sprout-ws-client (#876)
  docs(sprout-acp): add communication discipline rules to base prompt + deprecate --mention flag (#883)
  Polish thread summaries and reactions (#881)
  feat(cli): add emoji export and import subcommands (#882)
  Polish message row hover states (#880)
  Improve emoji naming and custom emoji UX (#878)
  docs: add ecosystem section to CONTRIBUTING.md, fix stale release info (#873)
  fix(relay): wire custom filter fields through HTTP bridge (#864)
  chore: deprecate sprout-mcp — fill CLI gaps, remove crate and all references (#850)
  Fix custom emoji status in profile popover (#874)
  fix(agent): gate handoff on provider token usage, not byte estimate (#821)
  docs: add VISION_MESH.md — the compute-commons vision (#867)
  fix(desktop): simplify profile popover header (#853)
  fix(desktop): remove thread comment hover outline (#861)
  feat(desktop): always show channel section search/add buttons (#856)

# Conflicts:
#	crates/sprout-cli/src/client.rs
#	desktop/src/app/AppShell.tsx
#	justfile
tellaho pushed a commit that referenced this pull request Jun 8, 2026
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants