Skip to content

Conversation

@kallu
Copy link

@kallu kallu commented Nov 2, 2020

Issue #, if available: #130

Description of changes:
Adding support for 'snapshotRequired' argument similar to one already in Java -plugin.
aws-cloudformation/cloudformation-cli-java-plugin#316

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…uested' (TypeError)" when creating a new resource.

#130
@ammokhov
Copy link
Contributor

ammokhov commented Nov 2, 2020

Issue #, if available: #130

Description of changes:
Adding support for 'snapshotRequired' argument similar to one already in Java -plugin.
aws-cloudformation/cloudformation-cli-java-plugin#316

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

thanks for the PR, this issue should be fixed by #127 but the update has not been released yet.

Copy link
Contributor

@ammokhov ammokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good but need to improve code coverage

@kallu
Copy link
Author

kallu commented Nov 7, 2020

I think is now obsolete as issue has been already fixed in cloudformation-cli-python-lib 2.1.3.

@kallu kallu closed this Nov 7, 2020
@tomwwright
Copy link

tomwwright commented Nov 11, 2020

I'm encountering this issue currently cloudformation-cli-python-lib 2.1.3 -- how exactly is it fixed?

EDIT: #130

@kallu
Copy link
Author

kallu commented Nov 11, 2020

The First thing to verify is you have version 2.1.3 in requirements.txt as cfn init is not yet updated and by default will use an older version. After updating cloudformation-cli-python-lib requirement to 2.1.3 it worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants