adding snapshot support #316
Conversation
aygold92
left a comment
There was a problem hiding this comment.
is there a way to test this end to end before we submit it?
| .logicalResourceIdentifier(request.getRequestData().getLogicalResourceId()) | ||
| .nextToken(request.getNextToken()) | ||
| .region(request.getRegion()) | ||
| .snapshotRequested(request.getSnapshotRequested()) |
There was a problem hiding this comment.
We should not add change in the generated code here. This will cause build break if only upgrade the PyPi java plugin.
The better place like this https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/blob/master/src/main/java/software/amazon/cloudformation/LambdaWrapper.java#L275
We won't even need tool release.
| private String region; | ||
| private String resourceType; | ||
| private String resourceTypeVersion; | ||
| private RequestData<ResourceT> requestData; |
There was a problem hiding this comment.
nit: should this be in request data instead? seems relatedto the actual request and not cloudformation metadata related info
There was a problem hiding this comment.
Good point, but TBH I don't really understand the distinction here anyways. Like, why are providerCredentials, providerLogGroupName, and logicalResourceId part of requestData while callbackContext, accountId, bearerToken, and action are not?
Issue #, if available:
Description of changes:
adding support for snapshot metadata
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.