Skip to content

Patch for "unexpected keyword argument 'snapshotRequested'" #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kallu wants to merge 1 commit into from
Closed

Patch for "unexpected keyword argument 'snapshotRequested'" #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/cloudformation_cli_python_lib/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,4 @@ class BaseResourceHandlerRequest:
region: Optional[str]
awsPartition: Optional[str]
stackId: Optional[str]
snapshotRequested: Optional[bool]
1 change: 1 addition & 0 deletions src/cloudformation_cli_python_lib/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ def _cast_resource_request(
logicalResourceIdentifier=request.requestData.logicalResourceId,
stackId=request.stackId,
region=request.region,
snapshotRequested=request.snapshotRequested,
).to_modelled(self._model_cls)
except Exception as e: # pylint: disable=broad-except
LOG.exception("Invalid request")
Expand Down
4 changes: 4 additions & 0 deletions src/cloudformation_cli_python_lib/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ class RequestData:
providerCredentials: Optional[Credentials] = None
previousResourceProperties: Optional[Mapping[str, Any]] = None
previousStackTags: Optional[Mapping[str, Any]] = None
snapshotRequested: Optional[bool] = None

@classmethod
def deserialize(cls, json_data: MutableMapping[str, Any]) -> "RequestData":
Expand Down Expand Up @@ -92,6 +93,7 @@ class HandlerRequest:
resourceTypeVersion: Optional[str] = None
callbackContext: Optional[MutableMapping[str, Any]] = None
nextToken: Optional[str] = None
snapshotRequested: Optional[bool] = None

def __init__(self, **kwargs: Any) -> None:
dataclass_fields = {f.name for f in fields(self)}
Expand Down Expand Up @@ -126,6 +128,7 @@ class UnmodelledRequest:
nextToken: Optional[str] = None
stackId: Optional[str] = None
region: Optional[str] = None
snapshotRequested: Optional[bool] = None

def to_modelled(self, model_cls: Type[BaseModel]) -> BaseResourceHandlerRequest:
# pylint: disable=protected-access
Expand All @@ -142,6 +145,7 @@ def to_modelled(self, model_cls: Type[BaseModel]) -> BaseResourceHandlerRequest:
stackId=self.stackId,
region=self.region,
awsPartition=self.get_partition(self.region),
snapshotRequested=self.snapshotRequested,
)

@staticmethod
Expand Down