Skip to content

[ISSUE #4062]Implement the method printRetryThreadPoolState() in EventMeshTcpRetryer #4063

Merged
mxsm merged 10 commits intoapache:masterfrom
pandaapo:master-issue4062
Aug 21, 2023
Merged

[ISSUE #4062]Implement the method printRetryThreadPoolState() in EventMeshTcpRetryer #4063
mxsm merged 10 commits intoapache:masterfrom
pandaapo:master-issue4062

Conversation

@pandaapo
Copy link
Member

@pandaapo pandaapo commented Jun 1, 2023 •
edited
Loading

Fixes #4062.

Motivation

The method printRetryThreadPoolState() in EventMeshTcpRetryer is an empty method.

Modifications

Implement the empty method.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Jun 5, 2023 •
edited
Loading

Codecov Report

Merging #4063 (371922e) into master (8f584d5) will increase coverage by 0.03%.
Report is 6 commits behind head on master.
The diff coverage is 52.17%.

❗ Current head 371922e differs from pull request most recent head e489790. Consider uploading reports for the commit e489790 to get more accurate results

@@             Coverage Diff              @@
##             master    #4063      +/-   ##
============================================
+ Coverage     17.81%   17.85%   +0.03%     
- Complexity     1512     1514       +2     
============================================
  Files           601      602       +1     
  Lines         25495    25518      +23     
  Branches       2400     2400              
============================================
+ Hits           4543     4555      +12     
- Misses        20514    20524      +10     
- Partials        438      439       +1
Files Changed Coverage Δ
...nnector/s3/source/connector/S3SourceConnector.java 0.00% <0.00%> (ø)
.../tcp/client/session/retry/EventMeshTcpRetryer.java 0.00% <0.00%> (ø)
...pache/eventmesh/runtime/util/ThreadPoolHelper.java 75.00% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

xwm1992
xwm1992 previously approved these changes Jun 6, 2023
View reviewed changes
@harshithasudhakar
Copy link
Member

harshithasudhakar commented Aug 17, 2023

@pandaapo Please resolve the conflicts

@pandaapo
Copy link
Member Author

pandaapo commented Aug 17, 2023

@pandaapo Please resolve the conflicts

It's OK now.

@pandaapo
Copy link
Member Author

pandaapo commented Aug 17, 2023

All compile errors caused by new method init(ConnectorContext) in org.apache.eventmesh.openconnect.api.connector.Connector.

Some checkstyle errors caused by PR #4379.

I found that these errors occurred in multiple modules, so I tried to fix them myself. @harshithasudhakar @xwm1992

harshithasudhakar
harshithasudhakar approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@harshithasudhakar harshithasudhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Aug 18, 2023
Merged
Closed
mxsm
mxsm approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit 50d6113 into apache:master Aug 21, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
@pandaapo
[ISSUE apache#4062]Implement the method printRetryThreadPoolState() i…
1239b88 
…n EventMeshTcpRetryer (apache#4063)

* Complete the method printRetryThreadPoolState().

* Modify as review.

* Modify as review.

* Implement the new method of Connector in mongodb conector. Optimize duplicate code in redis connector.

* Implement the new method of Connector in S3 connector module. Optimize some duplicate codes.

* Fix checkstyle error.

* Fix checkstyle error.

* Fix checkstyle error.

* Fix checkstyle error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alonexc Alonexc Alonexc left review comments

@mxsm mxsm mxsm approved these changes

@harshithasudhakar harshithasudhakar harshithasudhakar approved these changes

@xwm1992 xwm1992 xwm1992 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Implement the method printRetryThreadPoolState() in EventMeshTcpRetryer

5 participants

@pandaapo @harshithasudhakar @xwm1992 @mxsm @Alonexc