[ISSUE #4195] Do some code optimization.[SubscribeProcessor]#4383
[ISSUE #4195] Do some code optimization.[SubscribeProcessor]#4383xwm1992 merged 6 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
![]() |
![]() |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
.../main/java/org/apache/eventmesh/runtime/core/protocol/grpc/processor/SubscribeProcessor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/eventmesh/runtime/core/protocol/grpc/processor/SubscribeProcessor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/eventmesh/runtime/core/protocol/grpc/processor/SubscribeProcessor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/eventmesh/runtime/core/protocol/grpc/processor/SubscribeProcessor.java
Outdated
Show resolved
Hide resolved
|
The rest of CI errors are being fixed by PR #4063. |
|
I would like to extend my sincere thanks to @pandaapo and @Alonexc for their valuable assistance in resolving this PR. Their insights and guidance were instrumental in tackling the challenges effectively. 🙌🏼 This being my first open-source project, their help was incredibly valuable and made the experience much smoother. |
|
Welcome to the EventMesh community. ci error is not related to your pr, but you can try to fix it. |
|
@gautamsagar99 PR #4063 was merged. You can update your master branch and merge it into this. Then CI errors will be resolved. |
mxsm
left a comment
There was a problem hiding this comment.
@gautamsagar99 Merge or rebase master branch to fix CI.
Codecov Report
@@ Coverage Diff @@
## master #4383 +/- ##
============================================
+ Coverage 17.81% 17.84% +0.02%
- Complexity 1512 1514 +2
============================================
Files 601 602 +1
Lines 25495 25520 +25
Branches 2400 2400
============================================
+ Hits 4543 4555 +12
- Misses 20514 20526 +12
- Partials 438 439 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| private final EventMeshGrpcServer eventMeshGrpcServer; | ||
|
|
||
| private final transient GrpcType grpcType = GrpcType.WEBHOOK; | ||
| private static final GrpcType grpcType = GrpcType.WEBHOOK; |
There was a problem hiding this comment.
How about changing “grpcType” to “GRPC_TYPE”?
…pache#4383) * apache#4195 issue: Update SubscribeProcessor.java * apache#4195 issue: Modified SubscribeProcessor.java * apache#4195 issue:Fixed SubscribeProcessor.java * apache#4195 issue: Changed SubscribeProcessor.java * apache#4195 issue:Resolved Syntax Error in SubscribeProcessor.java * Commiting after removing CI Merge Errors


Fixes #4195
Motivation
To solve below two issues:
Modifications
Documentation