Skip to content

[ISSUE #4385]Fix CI failing to pass#4386

Closed
mxsm wants to merge 2 commits intoapache:masterfrom
mxsm:eventmesh-4385
Closed

[ISSUE #4385]Fix CI failing to pass#4386
mxsm wants to merge 2 commits intoapache:masterfrom
mxsm:eventmesh-4385

Conversation

@mxsm
Copy link
Member

@mxsm mxsm commented Aug 20, 2023

Fixes #4385

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

  • Fix CI failing to pass

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #4386 (73db9a0) into master (8f584d5) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 73db9a0 differs from pull request most recent head b13670e. Consider uploading reports for the commit b13670e to get more accurate results

@@             Coverage Diff              @@
##             master    #4386      +/-   ##
============================================
- Coverage     17.81%   17.81%   -0.01%     
  Complexity     1512     1512              
============================================
  Files           601      601              
  Lines         25495    25505      +10     
  Branches       2400     2400              
============================================
  Hits           4543     4543              
- Misses        20514    20524      +10     
  Partials        438      438              
Files Changed Coverage Δ
...esh/connector/s3/source/config/S3SourceConfig.java 0.00% <0.00%> (ø)
...nnector/s3/source/connector/S3SourceConnector.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pandaapo
Copy link
Member

pandaapo commented Aug 20, 2023

These were being fixed in PR #4063.

@mxsm mxsm closed this Aug 21, 2023
@mxsm
Copy link
Member Author

mxsm commented Aug 21, 2023

These were being fixed in PR #4063.

@pandaapo I closed this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Fix CI failing to pass

3 participants