Merged
Conversation
Filled with (0, 0, 1) where alpha was < 1 Re-normalized all normals and replaced invalid values with (0, 0, 1) Set alpha channel to 1
This normalize should not be necessary, but the specific normal map of lower LODs of the palm trees otherwise generate NaNs during tangent to world space transformation.
Verasl
added a commit
that referenced
this pull request
Feb 4, 2020
* Updated burst package, fixed missing renderer shaders * Update package to public 7.0.0 package * Update BushTest normal map Filled with (0, 0, 1) where alpha was < 1 Re-normalized all normals and replaced invalid values with (0, 0, 1) Set alpha channel to 1 * Vegetation ShaderGraph: Normalize normal before master node This normalize should not be necessary, but the specific normal map of lower LODs of the palm trees otherwise generate NaNs during tangent to world space transformation. * Bugfix/nan (#53) * Update BushTest normal map Filled with (0, 0, 1) where alpha was < 1 Re-normalized all normals and replaced invalid values with (0, 0, 1) Set alpha channel to 1 * Vegetation ShaderGraph: Normalize normal before master node This normalize should not be necessary, but the specific normal map of lower LODs of the palm trees otherwise generate NaNs during tangent to world space transformation. * Update README.md * Update LICENSE changed Boat Attack License to UCL * Rename LICENSE to LICENSE.md * Fixed typo in welcome screen Co-authored-by: Florian Penzkofer <fp@nullptr.de>
Verasl
added a commit
that referenced
this pull request
Feb 10, 2020
* Fixed typo in welcome screen * Release/2019.3 (#68) * Updated burst package, fixed missing renderer shaders * Update package to public 7.0.0 package * Update BushTest normal map Filled with (0, 0, 1) where alpha was < 1 Re-normalized all normals and replaced invalid values with (0, 0, 1) Set alpha channel to 1 * Vegetation ShaderGraph: Normalize normal before master node This normalize should not be necessary, but the specific normal map of lower LODs of the palm trees otherwise generate NaNs during tangent to world space transformation. * Bugfix/nan (#53) * Update BushTest normal map Filled with (0, 0, 1) where alpha was < 1 Re-normalized all normals and replaced invalid values with (0, 0, 1) Set alpha channel to 1 * Vegetation ShaderGraph: Normalize normal before master node This normalize should not be necessary, but the specific normal map of lower LODs of the palm trees otherwise generate NaNs during tangent to world space transformation. * Update README.md * Update LICENSE changed Boat Attack License to UCL * Rename LICENSE to LICENSE.md * Fixed typo in welcome screen Co-authored-by: Florian Penzkofer <fp@nullptr.de> * fixes - fixed precision error in checkpoint shader - fixed tangents on clouds - fixed touch controls appearing on switch - clamped skybox sun - changed reflection probes to baked * Fixed Issue with addressables * Added back Heightmap generation for the Water * fixed DX11 sampler Co-authored-by: Florian Penzkofer <fp@nullptr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to avoid NaN with HDR rendering on Android devices.
Note: more fixes coming to SRP repo