Skip to content

Remove defunct in.place argument to droplevels() method#6833

Merged
MichaelChirico merged 2 commits intomasterfrom
depr-inplace
Mar 10, 2025
Merged

Remove defunct in.place argument to droplevels() method#6833
MichaelChirico merged 2 commits intomasterfrom
depr-inplace

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Feb 23, 2025

Finishing the deprecation cycle: #6316 -> #6652

Copy link
Copy Markdown
Member Author

MichaelChirico commented Feb 23, 2025

@MichaelChirico MichaelChirico changed the title Remove defunct in.place Remove defunct in.place argument to droplevels() method Feb 23, 2025
@MichaelChirico MichaelChirico marked this pull request as ready for review February 23, 2025 06:39
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (7e41884) to head (38550a4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6833      +/-   ##
==========================================
- Coverage   98.59%   98.59%   -0.01%     
==========================================
  Files          79       79              
  Lines       14662    14661       -1     
==========================================
- Hits        14456    14455       -1     
  Misses        206      206              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 23, 2025

Comparison Plot

Generated via commit 38550a4

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 30 seconds
Installing different package versions 8 minutes and 3 seconds
Running and plotting the test cases 2 minutes and 18 seconds

Copy link
Copy Markdown
Member

@ben-schwen ben-schwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY

Base automatically changed from depr-autostart to master March 10, 2025 19:48
@MichaelChirico MichaelChirico merged commit bdd7e2d into master Mar 10, 2025
10 checks passed
@MichaelChirico MichaelChirico deleted the depr-inplace branch March 10, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants