Skip to content

Progress deprecated option 'datatable.nomatch' to error#6644

Merged
ben-schwen merged 3 commits intomasterfrom
nomatch-option-error
Mar 12, 2025
Merged

Progress deprecated option 'datatable.nomatch' to error#6644
ben-schwen merged 3 commits intomasterfrom
nomatch-option-error

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Dec 10, 2024

This has been warning for 3 years, though the CRAN version has only been warning for 1 year, hence targeting this for 1.18.0

@MichaelChirico MichaelChirico added this to the 1.18.0 milestone Dec 10, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (fe8b3b1) to head (edc8695).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6644   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          79       79           
  Lines       14660    14660           
=======================================
  Hits        14454    14454           
  Misses        206      206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 10, 2024

Comparison Plot

Generated via commit edc8695

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 37 seconds
Installing different package versions 8 minutes and 7 seconds
Running and plotting the test cases 2 minutes and 19 seconds

@MichaelChirico MichaelChirico requested review from ben-schwen and removed request for ben-schwen December 30, 2024 05:31
@MichaelChirico MichaelChirico changed the base branch from master to graphite-base/6644 February 25, 2025 06:34
@MichaelChirico MichaelChirico changed the base branch from graphite-base/6644 to depr-withset February 25, 2025 06:34
Copy link
Copy Markdown
Member Author

MichaelChirico commented Feb 25, 2025

@ben-schwen ben-schwen merged commit 3afc750 into master Mar 12, 2025
12 checks passed
@ben-schwen ben-schwen deleted the nomatch-option-error branch March 12, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants