Setdroplevels for in-place removal of unused levels#6316
Merged
MichaelChirico merged 6 commits intomasterfrom Jul 30, 2024
Merged
Setdroplevels for in-place removal of unused levels#6316MichaelChirico merged 6 commits intomasterfrom
MichaelChirico merged 6 commits intomasterfrom
Conversation
|
Generated via commit 52c995a Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 11 minutes and 28 seconds Time taken to run |
Member
|
LGTM, but would like to hear @jangorecki opinion on the depcrecation part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6014
Tests feel a bit sparse, but I think we're basically covered by existing
droplevels.data.table()tests, didn't know how much time to spend on redundant testing.Given that
setdroplevels()is a pretty easy drop-in replacement fordroplevels(in.place=TRUE), and we didn't find any downstream usage, I didn't add an opt-out mechanism for this, LMYK if you think we should be more cautious.