[https://nvbugs/6550803][fix] Pin Mock(_force_non_greedy_for_capture=False) at the test's spec_metadata… - #17219
Open
trtllm-agent wants to merge 1 commit into
Open
Conversation
…pling override Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
trtllm-agent
requested review from
EmmaQiaoCh,
JunyiXu-nv,
allisonlim-nv,
brnguyen2,
crazydemo,
mlefeb01 and
schetlur-nv
August 3, 2026 19:51
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughThe speculative decoding test fixture now sets ChangesSpeculative decoding test correction
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mock()asspec_metadata, sogetattr(spec_metadata, '_force_non_greedy_for_capture', False)returned a truthy auto-vivified child Mock instead ofFalse, tripping the production assert that guards the capture-only sampling override.Mock(_force_non_greedy_for_capture=False)at the test's spec_metadata double (the convention already used at line 231 of the same file), leaving the production guard intact, and remove the obsolete waiver.Test plan
Links
Dev Engineer Review
spec_metadatato set_force_non_greedy_for_capture=False.Mockauto-vivification from triggering the production assertion.Verdict: sufficient.
QA Engineer Review
test_promoted_context_precedes_speculative_overlap_generation.tests/integration/test_lists/waives.txt.Verdict: sufficient.