[https://nvbugs/6550727][fix] Pin _force_non_greedy_for_capture=False on the test double so it models a… - #17205
Open
trtllm-agent wants to merge 1 commit into
Open
Conversation
…test double The bare Mock() used as spec_metadata auto-vivifies every attribute, so getattr(spec_metadata, '_force_non_greedy_for_capture', False) in _prepare_tp_inputs never reached its False default and read a truthy child Mock instead, tripping the capture-override assert added in b118fc3. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe speculative-overlap test now explicitly sets ChangesCapture Mock Behavior
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mock()asspec_metadata, andMockauto-vivifies attributes, so the capture-overridegetattr(..., False)returned a truthy child Mock and tripped the assert._force_non_greedy_for_capture=Falseon the test double so it models a realSpecMetadataoutside warmup, leaving the production serving-correctness guard intact.Test plan
Links
Dev Engineer Review
_force_non_greedy_for_capture=False.SpecMetadatabehavior outside warmup.QA Engineer Review
tests/unittest/_torch/executor/test_pytorch_model_engine.py.tests/integration/test_lists/could not be confirmed.Verdict: needs follow-up