Skip to content

[None][infra] Waive 2 failed cases for main in pre-merge 51267 - #17182

Closed
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260803-061427
Closed

[None][infra] Waive 2 failed cases for main in pre-merge 51267#17182
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260803-061427

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @dominicshanshan)
Target branch: main
Bug(s): 6550727

Waive entries added

unittest/_torch/executor SKIP (https://nvbugs/6550727)
unittest/_torch/executor/test_pytorch_model_engine.py::PyTorchModelEngineTestCase::test_promoted_context_precedes_speculative_overlap_generation SKIP (https://nvbugs/6550727)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added two waiver entries in tests/integration/test_lists/waives.txt.
  • Both entries reference NVIDIA bug 6550727.
  • The test paths match the reported failed pre-merge cases.
  • No duplicate or format issues were identified.
  • No public entities or APIs changed.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Added waivers for:
    • _torch/executor
    • unittest/_torch/executor/test_pytorch_model_engine.py::PyTorchModelEngineTestCase::test_promoted_context_precedes_speculative_overlap_generation
  • No test-db or QA files were modified.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Bug(s): 6550727
Requested by: @dominicshanshan

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The integration waiver list adds skipped entries for the _torch/executor suite and test_promoted_context_precedes_speculative_overlap_generation. Both entries reference NVIDIA bug 6550727.

Changes

Integration test waivers

Layer / File(s) Summary
Bug-linked waiver entries
tests/integration/test_lists/waives.txt
Adds skip waivers for the _torch/executor suite and the promoted-context precedence test. Both entries reference bug 6550727.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: qijune, dpitman-nvda

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the infrastructure change and the two waived failed cases for the main branch.
Description check ✅ Passed The description explains the waiver purpose, identifies bug 6550727, and lists both affected test cases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 381-382: Update the modified waives.txt file with the required
NVIDIA copyright header, including the current year 2026, while preserving the
existing skip entries.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 30301f95-17e9-46bf-8a0d-1b45227456cd

📥 Commits

Reviewing files that changed from the base of the PR and between c0836f0 and 56412dc.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment on lines +381 to +382
unittest/_torch/executor SKIP (https://nvbugs/6550727)
unittest/_torch/executor/test_pytorch_model_engine.py::PyTorchModelEngineTestCase::test_promoted_context_precedes_speculative_overlap_generation SKIP (https://nvbugs/6550727)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add or update the NVIDIA copyright header.

The modified file has no visible NVIDIA copyright header or year. Add the required header with the current year, 2026.

As per coding guidelines, modified files must have the NVIDIA copyright year updated.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` around lines 381 - 382, Update the
modified waives.txt file with the required NVIDIA copyright header, including
the current year 2026, while preserving the existing skip entries.

Source: Coding guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants