Skip to content

fix: handle invalid maxOutputTokens value (0 or undefined)#1

Open
Jedeiah wants to merge 426 commits into
devfrom
fix/maxOutputTokens-validation
Open

fix: handle invalid maxOutputTokens value (0 or undefined)#1
Jedeiah wants to merge 426 commits into
devfrom
fix/maxOutputTokens-validation

Conversation

@Jedeiah
Copy link
Copy Markdown
Owner

@Jedeiah Jedeiah commented Apr 11, 2026

Fixes anomalyco#21858
Fixes anomalyco#21522

What

  • Fixes maxOutputTokens returning 0 when model.limit.output is 0, undefined, or negative
  • Returns OUTPUT_TOKEN_MAX (32000) as fallback when model output limit is invalid

Why

  • When plugins pass maxOutputTokens=0 via chat.params hook, OpenCode 1.4.0+ requires >= 1
  • This causes "maxOutputTokens must be >= 1" error for local providers like Ollama

Verification

  • Added 5 unit tests for maxOutputTokens function covering edge cases
  • All tests pass

kitlangton and others added 30 commits April 15, 2026 16:35
@kitlangton
fix: register OTel context manager so AI SDK spans thread into Effect…
9640d88 
… traces (anomalyco#22645)
@opencode-agent
chore: update nix node_modules hashes
8ba4799
@rekram1-node @opencode-agent
fix: ensure tool_use is always followed by tool_result (anomalyco#22646)
348a849 
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
@rekram1-node @opencode-agent
tweak: ensure auto continuing compaction is tracked as agent initiate…
e83b221 
…d for github copilot (anomalyco#22567)

Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
@kitlangton
add experimental permission HttpApi slice (anomalyco#22385)
250e30b
@opencode-agent
chore: generate
3b75f16
@kitlangton
feat(opencode): improve telemetry tracing and request spans (anomalyc…
6bed7d4 
…o#22653)
@ariane-emory
fix(core): Remove dead code and documentation related to the obsolete…
d2ea670 
… list tool. (anomalyco#22672)
@Brendonovich
core: move plugin intialisation to config layer override (anomalyco#2…
916131b 
…2620)
@opencode-agent
chore: generate
83e257b
@iamdavidhill @adamdotdevin @Brendonovich
tweak(ui): session spacing (anomalyco#20839)
e16589f 
Co-authored-by: Adam <2363879+adamdotdevin@users.noreply.github.com>
Co-authored-by: Brendan Allan <brendonovich@outlook.com>
@kitlangton
fix(opencode): avoid org lookup during config startup (anomalyco#22670)
672ee28
@kitlangton
refactor(opencode): use AppFileSystem path helpers (anomalyco#22637)
4dd0d1f
@CarloWood
fix(tui): Don't overwrite the agent that was specified on the command…
a554fad 
… line (anomalyco#20554)
@kitlangton
feat: add oxlint with correctness defaults (anomalyco#22682)
3d6f90c
@opencode-agent
chore: generate
ac2fa66
@kitlangton
feat(shared): add Effect-idiomatic file lock (EffectFlock) (anomalyco…
a147ad6 
…#22681)
@kitlangton
fix(session): retry 5xx server errors even when isRetryable is unset (a…
4ca809e 
…nomalyco#22511)
@jlongster
feat(core): add fence to make all methods strongly consistent when sy…
074ef03 
…ncing (anomalyco#22679)
@rekram1-node
fix: bash memory usage (anomalyco#22660)
307251b
@kitlangton
fix: revert "core: move plugin initialisation to config layer overrid…
6d42f97 
…e" (anomalyco#22686)
@kitlangton
feat: namespace → flat export migration (Bus proof-of-concept) (anoma…
02f2cf4 
…lyco#22685)
@kitlangton
refactor: remove makeRuntime facades from File and Ripgrep (anomalyco…
0fb0135 
…#22513)
@kitlangton
feat: unwrap Config namespace to flat exports + barrel (anomalyco#22689)
bbdbc10
@kitlangton
fix: resolve oxlint warnings — suppress false positives, remove unuse…
f7d4665 
…d imports (anomalyco#22687)
@kitlangton
feat: unwrap Provider namespace + improved automation script (anomaly…
1d81335 
…co#22690)
@opencode-agent
chore: generate
7baf998
@kitlangton
feat: unwrap MCP namespace to flat exports + barrel (anomalyco#22693)
6625766
@kitlangton
fix: prefix 32 unused parameters with underscore (anomalyco#22694)
d6b14e2
@opencode-agent
chore: generate
70aeebf
jlongster and others added 30 commits April 16, 2026 23:35
@jlongster
fix(tui): tui resiliency when workspace is dead, disable directory fi…
0bedea5 
…lter in session list (anomalyco#23013)
@kitlangton
refactor(tui): inline final Go shimmer settings (anomalyco#23017)
4260c40
@opencode-agent
chore: generate
67dbb3c
@kitlangton
refactor: move project read routes onto HttpApi (anomalyco#23003)
9ee89f7
@Brendonovich
fix(app): use fetchQuery instead of ensureQueryData in global sync (a…
79e9baf 
…nomalyco#23025)
@opencode-agent
chore: update nix node_modules hashes
dfaae14
@thdxr
fix: preserve prompt input across unmount/remount cycles (anomalyco#2…
4bd5a15 
…2508)
@rekram1-node
chore: delete filetime module (anomalyco#22999)
76a1410
@opencode-agent
chore: generate
f0caeb9
@jlongster
remove accidental commit of daytona plugin (anomalyco#23030)
72d7cb7
@thdxr
fix crash on experimental
e7f8f7f
@jlongster
refactor(core): move server routes around to clarify workspacing (ano…
7605acf 
…malyco#23031)
@Jedeiah
Merge branch 'dev' into fix/maxOutputTokens-validation
1db93bb
@thdxr
fade in prompt metadata transitions (anomalyco#23037)
65b2a10
@opencode-agent
chore: generate
81f0885
@thdxr
core: migrate config loading to Effect framework (anomalyco#23032)
d995059
@Brendonovich
fix(app): workspace loading and persist ready state (anomalyco#23046)
a726530
@opencode-agent
chore: generate
c57c531
@kommander
upgrade opentui to 0.1.100 (anomalyco#22928)
ec3ac0c
@opencode-agent
chore: update nix node_modules hashes
e78d75a
release: v1.4.8
06ae439
@thdxr
remove log
fffc496
@jlongster
feat(core): exponential backoff of workspace reconnect (anomalyco#23083)
0f80c82
@opencode-agent
chore: generate
cb425ac
@fwang
zen: routing logic
3707e4a
@opencode-agent
chore: generate
cc063d4
@thdxr
back to opentui 0.1.99
7e39c9b
@thdxr
roll back opentui
10c4ab9
@fwang
sync
20103eb
@Jedeiah
Merge branch 'dev' into fix/maxOutputTokens-validation
b9c25b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Ollama integration: Invalid maxOutputTokens error Invalid argument for parameter maxOutputTokens: maxOutputTokens must be >= 1