Skip to content

fix: revert "core: move plugin initialisation to config layer override"#22686

Merged
kitlangton merged 1 commit into
devfrom
fix/revert-plugin-priority
Apr 16, 2026
Merged

fix: revert "core: move plugin initialisation to config layer override"#22686
kitlangton merged 1 commit into
devfrom
fix/revert-plugin-priority

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • Reverts 916131b which moved plugin.init() from InstanceBootstrap into a ConfigWithPluginPriority layer wrapper
  • The wrapper called plugin.init() on every config.get(), but plugin.init() requires Instance context (via InstanceState), which isn't available when Config is read before Instance.provide (e.g. the worker's first RPC fetch)
  • This caused a startup crash: No context found for instance
  • Plugin init stays in InstanceBootstrap where it has proper instance context

@kitlangton kitlangton merged commit 6d42f97 into dev Apr 16, 2026
11 checks passed
@kitlangton kitlangton deleted the fix/revert-plugin-priority branch April 16, 2026 01:14
jerome-benoit pushed a commit to jerome-benoit/opencode that referenced this pull request Apr 16, 2026
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
dgokeeffe pushed a commit to dgokeeffe/opencode-databricks that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant