fix: resolve oxlint warnings — suppress false positives, remove unused imports#22687
Merged
Conversation
1820eab to
3f2b3b7
Compare
…d imports and dead code Suppress 3 rules that produce false positives for this codebase: - no-unused-expressions (SolidJS reactivity tracking pattern) - no-control-regex (intentional ANSI/null byte matching) - triple-slash-reference (required by SST and plugin tools) Remove 76 unused imports, 22 unused catch bindings, fix useless length checks, non-null after optional chain, useless catch/spread, and add inline suppressions for intentional patterns (self-assign reactivity triggers, while(true) loops, async promise executors). Reduces oxlint warnings from 249 to 100 (all remaining are no-unused-vars needing manual judgment).
3f2b3b7 to
8a3c128
Compare
jerome-benoit
pushed a commit
to jerome-benoit/opencode
that referenced
this pull request
Apr 16, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
dgokeeffe
pushed a commit
to dgokeeffe/opencode-databricks
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
while(true), async promise executors)Reduces oxlint warnings from 249 to 100. All remaining are
no-unused-vars(unused params, variables, functions) that need manual review per-case.Rules suppressed in config
no-unused-expressionscreateEffectfor trackingno-control-regextriple-slash-referenceFixes applied
catch (e)->catchwhere error was unused.length > 0 &&before.some()?.foo!non-null after optional chain[...map.keys()]->map.keys()in for-ofnew Array(n)->Array.from()(serialize.ts)oxlint-disablecomments for intentional patterns