Fix failed tests related to google_service_networking_connection by zli82016 · Pull Request #8904 · GoogleCloudPlatform/magic-modules

zli82016 · 2023-09-08T23:32:45Z

The previous PR #8872 caused some nightly tests failed.

To delete the google_service_networking_connection resource, call the method deleteConnection. If it fails, return the error and the deletion fails. Based on the test results, only sql instance has a waiting period to delete the connection.
Use bootstrapped service networking connection for handwritten tests.
For mm1 generated tests, create a new service networking connection, which can be deleted with deleteConnection. The reason to not use bootstrapped service networking connection is to not modify the examples in the doc.

5.0 guide is in #9009

Release Note Template for Downstream PRs (will be copied)

servicenetworking: used the `deleteConnection` method to delete the resource `google_service_networking_connection`

modular-magician · 2023-09-08T23:41:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 19 files changed, 59 insertions(+), 61 deletions(-))
Terraform Beta: Diff ( 20 files changed, 62 insertions(+), 64 deletions(-))
TF OiCS: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))

modular-magician · 2023-09-09T00:52:02Z

Tests analytics

Total tests: 3004
Passed tests 2693
Skipped tests: 302
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIEndpoint_vertexAiEndpointNetwork

Get to know how VCR tests work

modular-magician · 2023-09-09T01:15:28Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample[Debug log]
TestAccApigeeEnvironmentIamBindingGenerated[Debug log]
TestAccApigeeEnvironmentIamMemberGenerated[Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample[Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated[Debug log]
TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample[Debug log]
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample[Debug log]
TestAccVertexAIIndexEndpoint_updated[Debug log]
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-11T00:04:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 19 files changed, 59 insertions(+), 61 deletions(-))
Terraform Beta: Diff ( 20 files changed, 62 insertions(+), 64 deletions(-))
TF OiCS: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))

modular-magician · 2023-09-11T01:14:26Z

Tests analytics

Total tests: 3008
Passed tests 2704
Skipped tests: 302
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceNetworkingConnection_create|TestAccServiceNetworkingConnection_update

Get to know how VCR tests work

modular-magician · 2023-09-11T01:24:09Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccServiceNetworkingConnection_create[Debug log]
TestAccServiceNetworkingConnection_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

shuyama1

As discussed offline, I believe bootstrapping is still needed for this PR

modular-magician · 2023-09-16T06:07:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 19 files changed, 295 insertions(+), 504 deletions(-))
Terraform Beta: Diff ( 19 files changed, 295 insertions(+), 504 deletions(-))
TF OiCS: Diff ( 3 files changed, 12 insertions(+), 12 deletions(-))

modular-magician · 2023-09-16T07:18:24Z

Tests analytics

Total tests: 3035
Passed tests 2689
Skipped tests: 304
Affected tests: 42

Action taken

Found 42 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_update|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbCluster_restore|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbBackup_update|TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccApigeeTargetServer_apigeeTargetServerTestExample|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccApigeeTargetServer_apigeeTargetServerTest_update|TestAccBackupDRManagementServer_backupDrManagementServerExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccCloudIdsEndpoint_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccMemcacheInstance_update|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccServiceNetworkingConnection_create|TestAccServiceNetworkingConnection_update|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange1|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccTPUNode_tpuNodeFullExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample

Get to know how VCR tests work

modular-magician · 2023-09-16T09:08:24Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_alloydbInstanceBasicExample[Debug log]
TestAccAlloydbBackup_alloydbBackupBasicExample[Debug log]
TestAccAlloydbBackup_alloydbBackupFullExample[Debug log]
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample[Debug log]
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample[Debug log]
TestAccApigeeEnvironmentIamMemberGenerated[Debug log]
TestAccApigeeEnvironmentIamBindingGenerated[Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated[Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTestExample[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccApigeeTargetServer_apigeeTargetServerTest_update[Debug log]
TestAccBackupDRManagementServer_backupDrManagementServerExample[Debug log]
TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample[Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Debug log]
TestAccMemcacheInstance_memcacheInstanceBasicExample[Debug log]
TestAccRedisInstance_redisInstancePrivateServiceExample[Debug log]
TestAccServiceNetworkingConnection_create[Debug log]
TestAccServiceNetworkingConnection_update[Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Debug log]
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_createBackupWithMandatoryFields[Error message] [Debug log]
TestAccAlloydbBackup_usingCMEK[Error message] [Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Error message] [Debug log]
TestAccAlloydbInstance_update[Error message] [Debug log]
TestAccAlloydbInstance_createInstanceWithMaximumFields[Error message] [Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Error message] [Debug log]
TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance[Error message] [Debug log]
TestAccAlloydbCluster_restore[Error message] [Debug log]
TestAccAlloydbBackup_update[Error message] [Debug log]
TestAccCloudbuildWorkerPool_withNetwork[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Error message] [Debug log]
TestAccMemcacheInstance_update[Error message] [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange1[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[Error message] [Debug log]
TestAccTPUNode_tpuNodeFullExample[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-16T23:19:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 19 files changed, 295 insertions(+), 504 deletions(-))
Terraform Beta: Diff ( 19 files changed, 295 insertions(+), 504 deletions(-))
TF OiCS: Diff ( 3 files changed, 12 insertions(+), 12 deletions(-))

modular-magician · 2023-09-17T00:30:31Z

Tests analytics

Total tests: 3035
Passed tests 2709
Skipped tests: 304
Affected tests: 22

Action taken

Found 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbInstance_update|TestAccAlloydbCluster_restore|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbBackup_update|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudIdsEndpoint_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccMemcacheInstance_update|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange1|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccTPUNode_tpuNodeFullExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample

Get to know how VCR tests work

modular-magician · 2023-09-17T00:56:31Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Error message] [Debug log]
TestAccAlloydbBackup_usingCMEK[Error message] [Debug log]
TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance[Error message] [Debug log]
TestAccAlloydbInstance_update[Error message] [Debug log]
TestAccAlloydbCluster_restore[Error message] [Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Error message] [Debug log]
TestAccAlloydbInstance_createInstanceWithMaximumFields[Error message] [Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Error message] [Debug log]
TestAccAlloydbBackup_update[Error message] [Debug log]
TestAccCloudbuildWorkerPool_withNetwork[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Error message] [Debug log]
TestAccMemcacheInstance_update[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange1[Error message] [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Error message] [Debug log]
TestAccTPUNode_tpuNodeFullExample[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-17T06:13:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 19 files changed, 351 insertions(+), 648 deletions(-))
Terraform Beta: Diff ( 19 files changed, 351 insertions(+), 648 deletions(-))
TF OiCS: Diff ( 3 files changed, 12 insertions(+), 12 deletions(-))

modular-magician · 2023-09-17T15:51:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 19 files changed, 352 insertions(+), 646 deletions(-))
Terraform Beta: Diff ( 19 files changed, 352 insertions(+), 646 deletions(-))
TF OiCS: Diff ( 3 files changed, 12 insertions(+), 12 deletions(-))

modular-magician · 2023-09-17T17:02:18Z

Tests analytics

Total tests: 3035
Passed tests 2709
Skipped tests: 304
Affected tests: 22

Action taken

Found 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_update|TestAccAlloydbBackup_update|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbCluster_restore|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbBackup_usingCMEK|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudIdsEndpoint_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccMemcacheInstance_update|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_settings_checkServiceNetworking|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccTPUNode_tpuNodeFullExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIEndpoint_vertexAiEndpointNetwork

Get to know how VCR tests work

modular-magician · 2023-09-17T18:08:09Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_createInstanceWithMaximumFields[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_update[Error message] [Debug log]
TestAccAlloydbBackup_update[Error message] [Debug log]
TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance[Error message] [Debug log]
TestAccAlloydbCluster_restore[Error message] [Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Error message] [Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Error message] [Debug log]
TestAccCloudbuildWorkerPool_withNetwork[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Error message] [Debug log]
TestAccMemcacheInstance_update[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[Error message] [Debug log]
TestAccSqlDatabaseInstance_settings_checkServiceNetworking[Error message] [Debug log]
TestAccTPUNode_tpuNodeFullExample[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…ocatedIPRange

modular-magician · 2023-09-20T23:35:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 19 files changed, 396 insertions(+), 696 deletions(-))
Terraform Beta: Diff ( 19 files changed, 396 insertions(+), 696 deletions(-))
TF OiCS: Diff ( 3 files changed, 13 insertions(+), 13 deletions(-))

modular-magician · 2023-09-21T00:47:31Z

Tests analytics

Total tests: 3068
Passed tests 2753
Skipped tests: 307
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_restore|TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

modular-magician · 2023-09-21T01:09:16Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccProjectIamPolicy_invalidMembers[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Error message] [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-21T04:01:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 22 files changed, 463 insertions(+), 787 deletions(-))
Terraform Beta: Diff ( 22 files changed, 463 insertions(+), 787 deletions(-))
TF OiCS: Diff ( 3 files changed, 13 insertions(+), 13 deletions(-))

modular-magician · 2023-09-21T05:21:18Z

Tests analytics

Total tests: 3068
Passed tests 2756
Skipped tests: 307
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydb

Get to know how VCR tests work

modular-magician · 2023-09-21T05:37:58Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydb[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

zli82016 · 2023-09-21T16:13:00Z

The failed tests are unrelated.

zli82016 force-pushed the fix-tests-service-networking branch from 1bba746 to e853455 Compare September 10, 2023 23:55

zli82016 requested review from a team, shuyama1 and slevenick and removed request for a team and slevenick September 11, 2023 16:43

shuyama1 reviewed Sep 14, 2023

View reviewed changes

zli82016 force-pushed the fix-tests-service-networking branch 2 times, most recently from 7624060 to fa4a1af Compare September 16, 2023 05:58

zli82016 force-pushed the fix-tests-service-networking branch from 9090d3f to f4264e9 Compare September 16, 2023 23:10

zli82016 force-pushed the fix-tests-service-networking branch from dafdb0e to bfc0ef1 Compare September 17, 2023 15:41

zli82016 force-pushed the fix-tests-service-networking branch from bfc0ef1 to 025e43e Compare September 17, 2023 21:45

zli82016 added 4 commits September 20, 2023 15:50

Fix tests

742d70f

Catch the error when deleteConnection fails

d1004c2

Fix test TestAccVertexAIIndexEndpoint_updated

b1f4420

Fix test TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAll…

40e1dc1

…ocatedIPRange

zli82016 force-pushed the fix-tests-service-networking branch from 45f8b09 to 40e1dc1 Compare September 20, 2023 23:25

Fix test

462a1ad

shuyama1 approved these changes Sep 21, 2023

View reviewed changes

Comment thread mmv1/third_party/terraform/services/alloydb/resource_alloydb_backup_test.go

zli82016 merged commit a98d8fb into FEATURE-BRANCH-major-release-5.0.0 Sep 21, 2023

GauravJain21 mentioned this pull request Sep 22, 2023

Add cross-region replication support to AlloyDB #9012

Merged

c2thorn mentioned this pull request Sep 27, 2023

Sync Feature branch major release 5.0.0 into main #9110

Merged

melinath mentioned this pull request Oct 27, 2023

google_service_networking_connection destroy calls appear to always fail in 5.x despite guidance hashicorp/terraform-provider-google#16275

Closed

zli82016 deleted the fix-tests-service-networking branch November 29, 2023 17:43

joekiller mentioned this pull request Jul 24, 2024

google_service_networking_connection uses servicenetworking.delete when google console utilizes networks.removePeering hashicorp/terraform-provider-google#18834

Open

Conversation

zli82016 commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Sep 8, 2023

Diff report

Uh oh!

modular-magician commented Sep 9, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 9, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

modular-magician commented Sep 11, 2023

Diff report

Uh oh!

modular-magician commented Sep 11, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 11, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

shuyama1 left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Sep 16, 2023

Diff report

Uh oh!

modular-magician commented Sep 16, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 16, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

modular-magician commented Sep 16, 2023

Diff report

Uh oh!

modular-magician commented Sep 17, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 17, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

modular-magician commented Sep 17, 2023

Breaking Change Detection Failed

Diff report

Uh oh!

modular-magician commented Sep 17, 2023

Diff report

Uh oh!

modular-magician commented Sep 17, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 17, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

modular-magician commented Sep 20, 2023

Diff report

Uh oh!

modular-magician commented Sep 21, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 21, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

modular-magician commented Sep 21, 2023

Diff report

Uh oh!

modular-magician commented Sep 21, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 21, 2023

Rerun these tests in REPLAYING mode to catch issues

zli82016 commented Sep 8, 2023 •

edited

Loading