Add cross-region replication support to AlloyDB by 199201shubhamsahu · Pull Request #9012 · GoogleCloudPlatform/magic-modules

199201shubhamsahu · 2023-09-20T03:27:12Z

To Create a Secondary Cluster, cluster_type and secondary_config are the additional fields to be mentioned in the cluster.
The secondary cluster is dependent on the primary instance and the same needs to be added in the config using the depends_on field.
The field continuous_backup_config.enabled needs to be set false as continuous backup is not supported for secondary clusters.
The deletion_policy is set to FORCE as the secondary instance that will be created in the secondary cluster can not be deleted independently, but instead the entire secondary cluster needs to be deleted forcefully along with its secondary instance.

  cluster_type = "SECONDARY"
  deletion_policy = "FORCE"
  secondary_config {
    primary_cluster_name = <fully qualified primary cluster name>
    // Eg: primary_cluster_name = google_alloydb_cluster.<primary_cluster_name>.name
  }

  continuous_backup_config {
    enabled = false
  }

  depends_on = [google_alloydb_instance.<primary_instance_name>]

Part of hashicorp/terraform-provider-google#13251

Release Note Template for Downstream PRs (will be copied)

alloydb: added `cluster_type` and `secondary_config` fields to support secondary clusters in `google_alloydb_cluster` resource.

google-cla · 2023-09-20T03:27:16Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

modular-magician · 2023-09-20T03:29:16Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-09-20T03:38:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 487 insertions(+))
Terraform Beta: Diff ( 4 files changed, 487 insertions(+))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 5 files changed, 136 insertions(+))

modular-magician · 2023-09-20T04:50:22Z

Tests analytics

Total tests: 3080
Passed tests 2744
Skipped tests: 299
Affected tests: 37

Action taken

Found 37 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary|TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig|TestAccAlloydbCluster_secondaryClusterMandatoryFields|TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccAlloydbCluster_maximumFields|TestAccAlloydbCluster_withNetworkConfig|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet|TestAccAlloydbCluster_continuousBackup_enabledByDefault|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_withNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_continuousBackup_update|TestAccAlloydbCluster_mandatoryFields|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccAlloydbCluster_update|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbCluster_restore|TestAccAlloydbInstance_update|TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable|TestAccAlloydbBackup_update|TestAccAlloydbCluster_usingCMEK|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable|TestAccAlloydbCluster_missingWeeklySchedule|TestAccAlloydbBackup_createBackupWithMandatoryFields

Get to know how VCR tests work

modular-magician · 2023-09-20T06:01:57Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary[Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterMandatoryFields[Debug log]
TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight[Debug log]
TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved[Debug log]
TestAccAlloydbCluster_alloydbClusterFullExample[Debug log]
TestAccAlloydbCluster_maximumFields[Debug log]
TestAccAlloydbCluster_withNetworkConfig[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicExample[Debug log]
TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet[Debug log]
TestAccAlloydbCluster_continuousBackup_enabledByDefault[Debug log]
TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_withNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_continuousBackup_update[Debug log]
TestAccAlloydbCluster_mandatoryFields[Debug log]
TestAccAlloydbCluster_alloydbClusterBasicExample[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbBackup_alloydbBackupFullExample[Debug log]
TestAccAlloydbBackup_alloydbBackupBasicExample[Debug log]
TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbCluster_usingCMEK[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable[Debug log]
TestAccAlloydbCluster_missingWeeklySchedule[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample[Error message] [Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Error message] [Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Error message] [Debug log]
TestAccAlloydbInstance_createInstanceWithMaximumFields[Error message] [Debug log]
TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

GauravJain21

nit for test files: indentation.

ScottSuarez

What does delete mean in this instance? How is the secondary cluster getting cleaned up ?

199201shubhamsahu · 2023-09-21T18:13:06Z

What does delete mean in this instance? How is the secondary cluster getting cleaned up ?

Delete for secondary cluster is the same as the primary cluster because the same API is called with the same url and parameter. So no modification is needed.

ScottSuarez

This looks good to me if the other reviewer signs off as well

ScottSuarez

Apologies, I just noticed the VCR failures. We'll need to fix those before moving forward. This change makes sense to me though in philosophy

modular-magician · 2023-09-21T22:52:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 489 insertions(+))
Terraform Beta: Diff ( 4 files changed, 489 insertions(+))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 5 files changed, 136 insertions(+))

modular-magician · 2023-09-22T00:05:53Z

Tests analytics

Total tests: 3082
Passed tests 2777
Skipped tests: 299
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccDataSourceGoogleServiceAccountAccessToken_basic

Get to know how VCR tests work

modular-magician · 2023-09-22T00:13:43Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample[Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Error message] [Debug log]
TestAccAlloydbInstance_createInstanceWithMaximumFields[Error message] [Debug log]
TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance[Error message] [Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

GauravJain21 · 2023-09-22T06:39:15Z

All of these tests are failing due to service networking issue that is being tracked here: #8904

Error: https://screenshot.googleplex.com/8vfrTwfM6sWqYG8
We should comment these tests, and re-enable them once the issue from service networking team is resolved.
I have created a bug here to track it and I will re-enable them once service networking issue is resolved. b/301367801

@199201shubhamsahu Please comment these tests and add their names in the bug attached above so that I will enable them afterwards. Before doing that, please check if these tests are passing on you machine or not.

The tests which are already attached in the bug were all passing on the local/cloudtop machine but were failing in the nightly run due to service networking issue attached above.

We shouldn't be blocked due an issue in an unrelated service to release our feature to Terraform.

modular-magician · 2023-09-25T05:23:04Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 497 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 5 files changed, 497 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 5 files changed, 136 insertions(+))

modular-magician · 2023-09-25T06:35:56Z

Tests analytics

Total tests: 3081
Passed tests 2780
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstationConfig_updateHostDetails

Get to know how VCR tests work

modular-magician · 2023-09-25T07:18:04Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkstationsWorkstationConfig_update[Debug log]
TestAccWorkstationsWorkstationConfig_updateHostDetails[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

modular-magician · 2023-09-25T15:50:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 497 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 5 files changed, 497 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 5 files changed, 136 insertions(+))

modular-magician · 2023-09-25T17:07:38Z

Tests analytics

Total tests: 3081
Passed tests 2780
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

modular-magician · 2023-09-25T17:16:17Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

ScottSuarez · 2023-09-26T19:34:41Z

@199201shubhamsahu could you pull changes into this PR so it can be merged? There are merge conflicts.

modular-magician · 2023-10-09T17:50:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1233 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1233 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 5 files changed, 164 insertions(+))

modular-magician · 2023-10-09T18:04:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1156 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1156 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 5 files changed, 157 insertions(+))

modular-magician · 2023-10-09T19:17:47Z

Tests analytics

Total tests: 3138
Passed tests 2792
Skipped tests: 318
Affected tests: 28

Action taken

Found 28 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbCluster_secondaryClusterAddAutomatedBackupPolicy|TestAccAlloydbCluster_secondaryClusterUsingCMEK|TestAccAlloydbCluster_secondaryClusterMandatoryFields|TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary|TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_alloydbUserBuiltinExample|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbUser_updateRoles_IAM|TestAccAlloydbUser_alloydbUserIamExample|TestAccAlloydbBackup_update|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccAlloydbCluster_restore|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_update|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccBigQueryDataTable_bigtable|TestAccDataprocJobIamPolicy

Get to know how VCR tests work

rileykarson · 2023-10-09T20:05:33Z

+`, context)
+}
+
+func TestAccAlloydbCluster_secondaryClusterUsingCMEK(t *testing.T) {


optional: We could consolidate the other secondary settings into a _full test if you wanted! Setting the fields at least once is the target.

Other than TestAccAlloydbCluster_secondaryClusterAddAutomatedBackupPolicy since that's an error. When we get to promotion we'll want to test promoting + setting that at the same time.

Other fields like initial_user, continuous_backup_config, automated_backup_policy can not be enabled or set, so keeping only basic secondary cluster.

Please let me know if you meant something else by _full test

Yes, will add all possible tests that exists in primary cluster to the promoted cluster tests as well

non-blocking: We should document those fields not being available for secondary clusters somewhere.

modular-magician · 2023-10-09T20:36:21Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterAddAutomatedBackupPolicy[Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Debug log]
TestAccAlloydbCluster_secondaryClusterMandatoryFields[Debug log]
TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample[Debug log]
TestAccAlloydbBackup_alloydbBackupBasicExample[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinExample[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbUser_updateRoles_IAM[Debug log]
TestAccAlloydbUser_alloydbUserIamExample[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicExample[Debug log]
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbBackup_alloydbBackupFullExample[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-10-09T20:58:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1163 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1163 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 5 files changed, 157 insertions(+))

modular-magician · 2023-10-09T22:10:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1135 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1135 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 4 files changed, 155 insertions(+))

rileykarson

One missing immutable, otherwise LGTM.

Co-authored-by: Riley Karson <rileykarson@google.com>

modular-magician · 2023-10-09T22:52:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1136 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1136 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 4 files changed, 155 insertions(+))

modular-magician · 2023-10-10T00:08:30Z

Tests analytics

Total tests: 3143
Passed tests 2815
Skipped tests: 318
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_update|TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_continuousBackup_update|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable|TestAccAlloydbCluster_secondaryClusterAddAutomatedBackupPolicy|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccAlloydbCluster_restore

Get to know how VCR tests work

modular-magician · 2023-10-10T00:50:32Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_continuousBackup_update[Debug log]
TestAccAlloydbCluster_secondaryClusterUpdate[Debug log]
TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable[Debug log]
TestAccAlloydbCluster_secondaryClusterAddAutomatedBackupPolicy[Debug log]
TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable[Debug log]
TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight[Debug log]
TestAccAlloydbCluster_restore[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Stale

Backport hashicorp/terraform-provider-google-beta#6474 To Create a Secondary Cluster, `cluster_type` and `secondary_config` are the additional fields to be mentioned in the cluster. The secondary cluster is dependent on the primary instance and the same needs to be added in the config using the `depends_on` field. The field continuous_backup_config.enabled needs to be set false as continuous backup is not supported for secondary clusters. The deletion_policy is set to FORCE as the secondary instance that will be created in the secondary cluster can not be deleted independently, but instead the entire secondary cluster needs to be deleted forcefully along with its secondary instance. ``` cluster_type = "SECONDARY" deletion_policy = "FORCE" secondary_config { primary_cluster_name = <fully qualified primary cluster name> // Eg: primary_cluster_name = google_alloydb_cluster.<primary_cluster_name>.name } continuous_backup_config { enabled = false } depends_on = [google_alloydb_instance.<primary_instance_name>] ``` Part of [hashicorp/terraform-provider-google#13251](hashicorp/terraform-provider-google#13251) **Release Note Template for Downstream PRs (will be copied)** ``` alloydb: added `cluster_type` and `secondary_config` fields to support secondary clusters in `google_alloydb_cluster` resource. ``` Derived from [GoogleCloudPlatform/magic-modules#9012](GoogleCloudPlatform/magic-modules#9012)

modular-magician requested a review from ScottSuarez September 20, 2023 03:29

GauravJain21 approved these changes Sep 20, 2023

View reviewed changes

Comment thread mmv1/templates/terraform/pre_create/alloydb_cluster.go.erb

ScottSuarez reviewed Sep 20, 2023

View reviewed changes

ScottSuarez approved these changes Sep 21, 2023

View reviewed changes

ScottSuarez requested changes Sep 21, 2023

View reviewed changes

modular-magician requested a review from ScottSuarez September 21, 2023 22:43

ScottSuarez approved these changes Sep 25, 2023

View reviewed changes

199201shubhamsahu closed this Sep 27, 2023

199201shubhamsahu force-pushed the alloydb-crr-support branch from 3578c66 to aef0da0 Compare September 27, 2023 23:43

Add fields for secondary cluster and create basic example

d787493

199201shubhamsahu reopened this Sep 28, 2023

modular-magician requested a review from ScottSuarez September 28, 2023 00:19

Add custom pre create code to support creation of secondary cluster

9c8ea97

Remove client_connection_config as it got rolled back

e6da0eb

rileykarson reviewed Oct 9, 2023

View reviewed changes

Add ImportStateVerifyIgnore to secondary cluster tests

70dcd5e

modular-magician requested a review from rileykarson October 9, 2023 20:48

199201shubhamsahu added 2 commits October 9, 2023 14:57

Set cluster_type as immutable and remove cluster_type update validation

ef48b6b

Remove cluster_type = PRIMARY as it is default value

89889d2

rileykarson reviewed Oct 9, 2023

View reviewed changes

Comment thread mmv1/products/alloydb/Cluster.yaml

Set secondaryConfig.primaryClusterName as immutable

559ce22

Co-authored-by: Riley Karson <rileykarson@google.com>

modular-magician requested a review from rileykarson October 9, 2023 22:44

rileykarson approved these changes Oct 10, 2023

View reviewed changes

rileykarson merged commit 79d5d56 into GoogleCloudPlatform:main Oct 10, 2023

cheftako mentioned this pull request Mar 25, 2024

[WIP] Backport Add cross-region replication support to AlloyDB GoogleCloudPlatform/k8s-config-connector#1421

Closed

2 tasks

199201shubhamsahu deleted the alloydb-crr-support branch April 11, 2024 23:50

melinath added the service/alloydb label Jun 7, 2024

Conversation

199201shubhamsahu commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla Bot commented Sep 20, 2023

Uh oh!

modular-magician commented Sep 20, 2023

Uh oh!

modular-magician commented Sep 20, 2023

Diff report

Uh oh!

modular-magician commented Sep 20, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 20, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

GauravJain21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ScottSuarez left a comment

Choose a reason for hiding this comment

Uh oh!

199201shubhamsahu commented Sep 21, 2023

Uh oh!

ScottSuarez left a comment

Choose a reason for hiding this comment

Uh oh!

ScottSuarez left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Sep 21, 2023

Diff report

Uh oh!

modular-magician commented Sep 22, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 22, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

GauravJain21 commented Sep 22, 2023

Uh oh!

modular-magician commented Sep 25, 2023

Diff report

Uh oh!

modular-magician commented Sep 25, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 25, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

modular-magician commented Sep 25, 2023

Diff report

Uh oh!

modular-magician commented Sep 25, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Sep 25, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

ScottSuarez commented Sep 26, 2023

Uh oh!

modular-magician commented Oct 9, 2023

Diff report

Uh oh!

modular-magician commented Oct 9, 2023

Diff report

Uh oh!

modular-magician commented Oct 9, 2023

Tests analytics

Action taken

Uh oh!

Uh oh!

Uh oh!

Uh oh!

199201shubhamsahu commented Sep 20, 2023 •

edited

Loading

rileykarson Oct 9, 2023 •

edited

Loading