Use Create instead of Patch to create google_service_networking_connection

[zli82016]

Fixes hashicorp/terraform-provider-google#10830

The bootstrapped network cannot be used, as an error is returned

Cannot modify allocated ranges in CreateConnection. Please use UpdateConnection.

Hope it will not affect the nightly tests so much.

The note is added to 5.0 guide in PR #8889

Release Note Template for Downstream PRs (will be copied)

servicenetworking: used Create instead of Patch to create `google_service_networking_connection`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 15 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3002
Passed tests 2660
Skipped tests: 301
Affected tests: 41

Action taken

Found 41 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbBackup_update|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbCluster_restore|TestAccAlloydbInstance_update|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbBackup_usingCMEK|TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccBackupDRManagementServer_backupDrManagementServerExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccCloudIdsEndpoint_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeGroupIndexUpdate|TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccMemcacheInstance_update|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccServiceNetworkingConnection_create|TestAccServiceNetworkingConnection_update|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccTPUNode_tpuNodeFullExample|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIEndpoint_vertexAiEndpointNetwork

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTestExample[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccApigeeEnvKeystore_apigeeEnvironmentKeystoreTestExample[Debug log]
TestAccApigeeEnvironmentIamMemberGenerated[Debug log]
TestAccApigeeEnvironmentIamBindingGenerated[Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated[Debug log]
TestAccBackupDRManagementServer_backupDrManagementServerExample[Debug log]
TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample[Debug log]
TestAccDataLossPreventionStoredInfoType_dlpStoredInfoTypeGroupIndexUpdate[Debug log]
TestAccServiceNetworkingConnection_create[Debug log]
TestAccServiceNetworkingConnection_update[Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Debug log]
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]
TestAccTPUNode_tpuNodeFullExample[Debug log]
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointExample[Debug log]
TestAccVertexAIIndexEndpoint_updated[Debug log]
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_createInstanceWithMaximumFields[Error message] [Debug log]
TestAccAlloydbBackup_update[Error message] [Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Error message] [Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicExample[Error message] [Debug log]
TestAccAlloydbBackup_alloydbBackupFullExample[Error message] [Debug log]
TestAccAlloydbBackup_alloydbBackupBasicExample[Error message] [Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Error message] [Debug log]
TestAccAlloydbCluster_restore[Error message] [Debug log]
TestAccAlloydbInstance_update[Error message] [Debug log]
TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance[Error message] [Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Error message] [Debug log]
TestAccAlloydbBackup_usingCMEK[Error message] [Debug log]
TestAccCloudbuildWorkerPool_withNetwork[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Error message] [Debug log]
TestAccMemcacheInstance_update[Error message] [Debug log]
TestAccMemcacheInstance_memcacheInstanceBasicExample[Error message] [Debug log]
TestAccRedisInstance_redisInstancePrivateServiceExample[Error message] [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 20 files changed, 133 insertions(+), 144 deletions(-))
Terraform Beta: Diff ( 20 files changed, 133 insertions(+), 144 deletions(-))
TF OiCS: Diff ( 7 files changed, 27 insertions(+), 27 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3002
Passed tests 2676
Skipped tests: 301
Affected tests: 25

Action taken

Found 25 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbBackup_update|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbCluster_restore|TestAccAlloydbInstance_createInstanceWithMaximumFields|TestAccAlloydbInstance_update|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudIdsEndpoint_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccDataprocClusterIamPolicy|TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccMemcacheInstance_update|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbInstance_createInstanceWithMaximumFields[Debug log]
TestAccCloudbuildWorkerPool_withNetwork[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_update[Error message] [Debug log]
TestAccAlloydbBackup_alloydbBackupBasicExample[Error message] [Debug log]
TestAccAlloydbBackup_alloydbBackupFullExample[Error message] [Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicExample[Error message] [Debug log]
TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance[Error message] [Debug log]
TestAccAlloydbCluster_restore[Error message] [Debug log]
TestAccAlloydbInstance_update[Error message] [Debug log]
TestAccCloudIdsEndpoint_basic[Error message] [Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Error message] [Debug log]
TestAccMemcacheInstance_update[Error message] [Debug log]
TestAccMemcacheInstance_memcacheInstanceBasicExample[Error message] [Debug log]
TestAccRedisInstance_redisInstancePrivateServiceExample[Error message] [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 20 files changed, 158 insertions(+), 176 deletions(-))
Terraform Beta: Diff ( 20 files changed, 158 insertions(+), 176 deletions(-))
TF OiCS: Diff ( 7 files changed, 27 insertions(+), 27 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3002
Passed tests 2687
Skipped tests: 301
Affected tests: 14

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbBackup_update|TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance|TestAccAlloydbInstance_update|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbCluster_restore|TestAccCloudIdsEndpoint_basic|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample|TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccMemcacheInstance_update|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupBasicExample[Debug log]
TestAccAlloydbBackup_alloydbBackupFullExample[Debug log]
TestAccAlloydbInstance_updateDatabaseFlagInPrimaryInstance[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicExample[Debug log]
TestAccCloudIdsEndpoint_basic[Debug log]
TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydbExample[Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Debug log]
TestAccMemcacheInstance_update[Debug log]
TestAccMemcacheInstance_memcacheInstanceBasicExample[Debug log]
TestAccRedisInstance_redisInstancePrivateServiceExample[Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_update[Error message] [Debug log]
TestAccAlloydbInstance_update[Error message] [Debug log]
TestAccAlloydbCluster_restore[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 20 files changed, 205 insertions(+), 221 deletions(-))
Terraform Beta: Diff ( 20 files changed, 205 insertions(+), 221 deletions(-))
TF OiCS: Diff ( 7 files changed, 27 insertions(+), 27 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 20 files changed, 205 insertions(+), 221 deletions(-))
Terraform Beta: Diff ( 20 files changed, 205 insertions(+), 221 deletions(-))
TF OiCS: Diff ( 7 files changed, 27 insertions(+), 27 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2993
Passed tests 2687
Skipped tests: 302
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbBackup_update|TestAccAlloydbInstance_update|TestAccAlloydbCluster_restore|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test