Add the note using Create method to create google_service_networking_connection to 5.0 guide#8889
Merged
Merged
Conversation
Collaborator
…connection to 5.0 guide
76e7263 to
caa9dd6
Compare
This was referenced Sep 7, 2023
Collaborator
Collaborator
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocJobIamPolicy |
Collaborator
|
Rerun these tests in REPLAYING mode to catch issues
|
c2thorn
requested changes
Sep 7, 2023
|
|
||
| ### `Create` method is used to create the resource | ||
|
|
||
| Previously, Patch instead of Create is used to create the resource, because an error message is returned when creating multiple SQL instances after creating `google_service_networking_connection` with Create method. See more details in https://issuetracker.google.com/issues/131908322. Now the issue has been fixed. The initial workaround of using Patch is no longer needed. Create method is used to create the resource. No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| Previously, Patch instead of Create is used to create the resource, because an error message is returned when creating multiple SQL instances after creating `google_service_networking_connection` with Create method. See more details in https://issuetracker.google.com/issues/131908322. Now the issue has been fixed. The initial workaround of using Patch is no longer needed. Create method is used to create the resource. | |
| `google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved. |
- I don't think we need to include the issue tracker, it wasn't particularly helpful for me understanding the issue.
- When you say "The initial workaround of using Patch is no longer needed" are you telling users to do something, or is it already taken care of?
- Are there any other specific steps the user needs to take when upgrading?
- Also, can we be more specific about Patch and Create? Like "Patch endpoint" or something?
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion.
- When you say "The initial workaround of using Patch is no longer needed" are you telling users to do something, or is it already taken care of?
- It is already taken care by using Create endpoint
- Are there any other specific steps the user needs to take when upgrading?
- The user does not need to take any other steps.
Collaborator
c2thorn
approved these changes
Sep 7, 2023
This was referenced Sep 7, 2023
RileyHYZ
pushed a commit
to RileyHYZ/magic-modules
that referenced
this pull request
Sep 15, 2023
…connection to 5.0 guide (GoogleCloudPlatform#8889) * Add the note using Create method to create google_service_networking_connection to 5.0 guide * Improve the note
joelkattapuram
pushed a commit
to joelkattapuram/magic-modules
that referenced
this pull request
Sep 20, 2023
…connection to 5.0 guide (GoogleCloudPlatform#8889) * Add the note using Create method to create google_service_networking_connection to 5.0 guide * Improve the note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)