Sync 5.0.0 with main#8785
Conversation
…tion profile. (#8675) * Make mysql_profile.password mutable to avoid recreation of the connection profile. The recreation of connection profile fails the streams permanently. They have to be recreated from the scratch. * Make fmt
* Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments
…builds vs ad hoc builds, add project descriptions (#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com>
* Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com>
* Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files
#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.
…andling (#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully
* Added some missing what's next links * reverted changes to run-tests.md
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
* Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <ScottSuarez@google.com> --------- Co-authored-by: Scott Suarez <ScottSuarez@google.com>
* add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…d Run V2 resources (#8771) * removed require * remove required for job
Co-authored-by: Edward Sun <sunedward@google.com>
Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
* Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <khimani@google.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 239 files changed, 3067 insertions(+), 5820 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
enable_fqdn_network_policy = # value needed
}
|
|
The breaking change - removal of |
Tests analyticsTotal tests: Action takenFound 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBiglakeCatalog_bigqueryBiglakeCatalogExample|TestAccCloudRunV2Service_cloudrunv2ServiceSecretExample|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccContainerCluster_withFQDNNetworkPolicy|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcUploadKeyExample|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample|TestAccIAMWorkforcePoolWorkforcePoolProvider_oidc|TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigSyntheticMonitorExample|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount|TestAccRedisCluster_redisClusterHaExample|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleServiceAccountAccessToken_basic |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 239 files changed, 3067 insertions(+), 5820 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
enable_fqdn_network_policy = # value needed
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataLossPreventionJobTrigger_dlpJobTriggerInspectCustomInfoTypes|TestAccSpannerInstanceIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)