Skip to content

Made breaking change detector own its own setup and build process#8705

Merged
melinath merged 21 commits into
mainfrom
b-296599247
Aug 24, 2023
Merged

Made breaking change detector own its own setup and build process#8705
melinath merged 21 commits into
mainfrom
b-296599247

Conversation

@melinath

Copy link
Copy Markdown
Member

This is the first step towards making this a single diff-processor library that will implement all diff-time tooling.

b/296599247


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

This comment was marked as outdated.

1 similar comment
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@melinath melinath requested a review from ScottSuarez August 18, 2023 20:57

@ScottSuarez ScottSuarez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we no longer base the breaking-change-detector unit tests off the customer's change we will likely want to communicate failure of the tool to execute/run.

We've had instances in the past where the breaking-change-detector would fail silently due to the package structure changes.

Comment thread .github/workflows/unit-tests-breaking-change-detector.yml
Comment thread .ci/scripts/go-plus/github-differ/generate_comment.sh Outdated
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

Comment thread .ci/scripts/go-plus/github-differ/generate_comment.sh Outdated
melinath and others added 2 commits August 22, 2023 11:57
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
@melinath melinath requested a review from ScottSuarez August 22, 2023 19:00
@modular-magician

This comment was marked as outdated.

Comment thread .ci/scripts/go-plus/github-differ/generate_comment.sh
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 86 deletions(-))
Terraform Beta: Diff ( 2 files changed, 86 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 86 deletions(-))
Terraform Beta: Diff ( 2 files changed, 86 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2987
Passed tests 2688
Skipped tests: 296
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbBackup_usingCMEK|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccDataprocJobIamPolicy

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_usingCMEK[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 86 deletions(-))
Terraform Beta: Diff ( 2 files changed, 86 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field encryption_config.kms_key_name within resource google_alloydb_backup was either removed or renamed - reference
  • Field encryption_config within resource google_alloydb_backup was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 86 deletions(-))
Terraform Beta: Diff ( 2 files changed, 86 deletions(-))
TF Conversion: Diff ( 1 file changed, 29 deletions(-))

@melinath melinath requested a review from ScottSuarez August 24, 2023 17:56
@melinath

Copy link
Copy Markdown
Member Author

@ScottSuarez that ended up taking a few more rounds than I was expecting to get right - could you take another look and verify the manual tests seem okay?

@@ -12,11 +12,14 @@ endif

clean:
cd old/; \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if these folders don't exist? will the command still succeed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no - you need to run make clone first (or set them up some other way.) See README changes for more details

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to address in a follow-on PR if you have concerns with this approach

@@ -29,22 +32,26 @@ endif
cd old/; \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if these folders don't exist? will the command still succeed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@ScottSuarez

Copy link
Copy Markdown
Contributor

Things look good from my perspective, I do have some outstanding questions about the MAKE failure scenarios but you can always address that in sequential PR

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2987
Passed tests 2691
Skipped tests: 296
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@melinath melinath merged commit 5f0068e into main Aug 24, 2023
@melinath melinath deleted the b-296599247 branch August 24, 2023 20:02
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 25, 2023
…ogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023
…ogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023
…ogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
melinath added a commit that referenced this pull request Sep 6, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (#8744)

* Made breaking change detector own its own setup and build process (#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (#8736)

* Cleanup deprecated folders (#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (#8761)

* Update example for google_compute_addresses data source (#8765)

* Remove myself from vacation list (#8770)

* Document database flags type change (#8769)

* Added some missing what's next links (#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (#8776)

* make distribution_policy_target_shape updatable (#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
…ogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

---------

Co-authored-by: Scott Suarez <ScottSuarez@google.com>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <sunedward@google.com>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <khimani@google.com>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Baruch Steinberg <baruch.steinberg@gmail.com>
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Co-authored-by: vaibhav-google <142835342+vaibhav-google@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>
Co-authored-by: Ryan Oaks <ryanoaks@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Daniel Koss <66844903+dkoss@users.noreply.github.com>
Co-authored-by: Ryan White <4404175+alzabo@users.noreply.github.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Sean McGivern <27fv8yygye@snkmail.com>
Co-authored-by: bohengy <108434983+bohengy@users.noreply.github.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Yanwei Guo <yanweiguo@google.com>
Co-authored-by: Edward Sun <42220489+edwardmedia@users.noreply.github.com>
Co-authored-by: Edward Sun <sunedward@google.com>
Co-authored-by: Tsubasa Nagasawa <toversus2357@gmail.com>
Co-authored-by: himanikh <himani.arora78@gmail.com>
Co-authored-by: Himani Khanduja <khimani@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants