Adds the synthetic monitor target type as an option for uptime checks.

[dkoss]

Fixes: hashicorp/terraform-provider-google#15207

This adds the new synthetic_monitor target type that is required for users who want to use the new GCM Synthetic Monitoring product.

See: https://cloud.google.com/monitoring/uptime-checks/introduction

Note for reviewer -- I (think I properly) ran acceptance tests, but it outputted "no tests to run". Is this right?

command / output

$ TF_LOG=TRACE make testacc TEST=./google TESTARGS='-run=TestAccMonitoringUptimeCheckConfig'
$ TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccMonitoringUptimeCheckConfig -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-google/google	0.329s [no tests to run]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

monitoring: added `synthetic_monitor` to `google_monitoring_uptime_check_config` resource

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 132 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 132 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 48 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_uptime_check_config (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_uptime_check_config" "primary" {
  synthetic_monitor {
    cloud_function_v2 {
      name = # value needed
    }
  }
}

[dkoss]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 132 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 2 files changed, 132 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 48 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_uptime_check_config (11 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_uptime_check_config" "primary" {
  synthetic_monitor {
    cloud_function_v2 {
      name = # value needed
    }
  }
}

Hi @zli82016 - I'm not sure how to address this feedback, as I need a FQN of a cloud function to provide to this name field. The other uptime acceptance tests seem to point at a vm's ip address, so I assume that there's vm somewhere in a test project that the ip belongs to. Do you know how I should proceed?

[zli82016]

google_monitoring_uptime_check_config

After checking the Github issue, you need to create a new resource google_cloudfunctions2_function and then let name points to the id of the new resource google_cloudfunctions2_function.

There are some examples in the code base https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/templates/terraform/examples, if you need to check.
For example,
https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/examples/cloudfunctions2_basic.tf.erb#L17

[modular-magician]

Tests analytics

Total tests: 2977
Passed tests 2672
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexDatascan_dataplexDatascanFullProfileExample|TestAccDataplexDatascan_dataplexDatascanBasicQualityExample|TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanFullProfileExample[Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicQualityExample[Debug log]
TestAccProjectIamPolicy_invalidMembers[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 196 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 196 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 48 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_uptime_check_config (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_uptime_check_config" "primary" {
  synthetic_monitor {
    cloud_function_v2 {
      name = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 2932
Passed tests 2642
Skipped tests: 290
Affected tests: 0

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 205 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 205 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 48 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_monitoring_uptime_check_config (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_monitoring_uptime_check_config" "primary" {
  synthetic_monitor {
    cloud_function_v2 {
      name = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 2932
Passed tests 2642
Skipped tests: 290
Affected tests: 0

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

[zli82016]

Can you please fix the unit tests? Thanks.

[dkoss]

Can you please fix the unit tests? Thanks.

Yep! Trying to fix these right now, currently dealing with a test failure that I dont understand. I just pushed the local version of my acceptance test which is reporting a failure. I'm going to continue trying to get this working, but is there something that's sticking out to you?

 make testacc TEST=./google/services/monitoring TESTARGS='-run=TestAccMonitoringUptimeCheckConfig_syntheticMonitor'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/monitoring -v -run=TestAccMonitoringUptimeCheckConfig_syntheticMonitor -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccMonitoringUptimeCheckConfig_syntheticMonitor
=== PAUSE TestAccMonitoringUptimeCheckConfig_syntheticMonitor
=== CONT  TestAccMonitoringUptimeCheckConfig_syntheticMonitor
    vcr_utils.go:152: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:


        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
        -/+ destroy and then create replacement

        Terraform will perform the following actions:

          # google_monitoring_uptime_check_config.primary must be replaced
        -/+ resource "google_monitoring_uptime_check_config" "primary" {
              ~ checker_type    = "STATIC_IP_CHECKERS" -> (known after apply)
                display_name    = "http-uptime-check-nxks"
              ~ id              = "projects/upmont-upmonter-upmontest/uptimeCheckConfigs/http-uptime-check-nxks-eQvMSGwEZhw" -> (known after apply)
              ~ name            = "projects/upmont-upmonter-upmontest/uptimeCheckConfigs/http-uptime-check-nxks-eQvMSGwEZhw" -> (known after apply)
                period          = "300s"
              ~ project         = "upmont-upmonter-upmontest" -> (known after apply)
                timeout         = "60s"
              ~ uptime_check_id = "http-uptime-check-nxks-eQvMSGwEZhw" -> (known after apply)

              + http_check {
                  + headers        = (known after apply)
                  + path           = "/"
                  + port           = (known after apply)
                  + request_method = "GET"
                }

                synthetic_monitor {
                    cloud_function_v2 {
                        name = "projects/upmont-upmonter-upmontest/locations/us-west1/functions/tf-synthetic-monitor-function-nxks"
                    }
                }
            }

        Plan: 1 to add, 0 to change, 1 to destroy.
--- FAIL: TestAccMonitoringUptimeCheckConfig_syntheticMonitor (97.77s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-google/google/services/monitoring	98.116s
FAIL
make: *** [GNUmakefile:15: testacc] Error 1

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 207 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 207 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 48 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 274 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 274 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 48 insertions(+))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2989
Passed tests 2691
Skipped tests: 296
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigSyntheticMonitorExample|TestAccMonitoringUptimeCheckConfig_syntheticMonitor

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigSyntheticMonitorExample[Error message] [Debug log]
TestAccMonitoringUptimeCheckConfig_syntheticMonitor[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 274 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 274 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 48 insertions(+))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 274 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 274 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 48 insertions(+))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 274 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 274 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 48 insertions(+))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))

[dkoss]

@zli82016 I think that I fixed everything that you requested + made the acceptance tests work / run. Can you take another look? Thanks!

[zli82016]

The command to run test should be

TF_LOG=TRACE make testacc TEST=./google/services/monitoring TESTARGS='-run=TestAccMonitoringUptimeCheckConfig'

[dkoss]

The command to run test should be

TF_LOG=TRACE make testacc TEST=./google/services/monitoring TESTARGS='-run=TestAccMonitoringUptimeCheckConfig'

Yep! I got things working now.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 256 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 256 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 48 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2988
Passed tests 2688
Skipped tests: 296
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[dkoss]

Tests passed during RECORDING mode: TestAccBigQueryDataTable_bigtable[Debug log] TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log] TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

Tests failed when rerunning REPLAYING mode: TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

Tests failed during RECORDING mode: TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Error message] [Debug log]

Please fix these to complete your PR. View the build log or the debug log for each test

@zli82016 -- it looks like there are some failures with completely unrelated tests. How should I proceed here?

[zli82016]

LGTM. Thanks.

[zli82016]

Tests passed during RECORDING mode: TestAccBigQueryDataTable_bigtable[Debug log] TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log] TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

Tests failed when rerunning REPLAYING mode: TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Error message] [Debug log]
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.
Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
Tests failed during RECORDING mode: TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Error message] [Debug log]
Please fix these to complete your PR. View the build log or the debug log for each test

@zli82016 -- it looks like there are some failures with completely unrelated tests. How should I proceed here?

They are unrelated. We can merge this PR.