Skip to content

Fixed edge case where async.include_project + exclude_delete caused compilation error #16586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melinath merged 1 commit into from
Mar 3, 2026
Merged

Fixed edge case where async.include_project + exclude_delete caused compilation error #16586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mmv1/templates/terraform/resource.go.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,9 +1059,6 @@ func resource{{ $.ResourceName -}}Update(d *schema.ResourceData, meta interface{

{{ end}}
func resource{{ $.ResourceName }}Delete(d *schema.ResourceData, meta interface{}) error {
{{- if and ($.GetAsync) (and (and ($.GetAsync.IsA "OpAsync") $.GetAsync.IncludeProject) ($.GetAsync.Allow "delete")) }}
var project string
{{- end }}
{{- if $.ExcludeDelete }}
log.Printf("[WARNING] {{ $.ProductMetadata.Name }}{{" "}}{{ $.Name }} resources" +
" cannot be deleted from Google Cloud. The resource %s will be removed from Terraform" +
Expand All @@ -1070,6 +1067,9 @@ func resource{{ $.ResourceName }}Delete(d *schema.ResourceData, meta interface{}

return nil
{{- else }}
{{- if and ($.GetAsync) (and (and ($.GetAsync.IsA "OpAsync") $.GetAsync.IncludeProject) ($.GetAsync.Allow "delete")) }}
var project string
{{- end }}
config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
if err != nil {
Expand Down
Loading