Fix/72889 - No action is triggered when user tap on "paste" option in compose box#73714
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hi @ZhenjaHorbach @Beamanator, the PR to update |
|
|
|
This PR is ready. |
trjExpensify
left a comment
There was a problem hiding this comment.
No qualms from me on the product here 👍
Beamanator
left a comment
There was a problem hiding this comment.
Looking good to me too, though v0.1.308 to v0.1.315 is a decent gap, do we need to be careful and make sure that the last 7 versions don't add anything that break the app? I'm not sure if they were added but reverted or something, would be good to check!
After reviewing all the versions, I think we just need to wait for #74036 — which bumps to 0.1.312 — to be merged. The other versions don't pose any risk. |
|
Good catch, i think that's for the best 👍 👍 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppNA Android: mWeb ChromeNA iOS: HybridApp2025-11-06.15.59.37.moviOS: mWeb Safari2025-11-06.15.59.37.movMacOS: Chrome / SafariNA MacOS: DesktopNA |
|
@dmkt9 |
@ZhenjaHorbach The conflict has been resolved. Thanks. |
|
LGTM! |
|
@ZhenjaHorbach should we wait for #74036? |
Actually yes |
|
@dmkt9 |
|
Thanks for the reminder. I've just merged it with the latest main. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
The typecheck failure isn't related to our PR |
|
@Beamanator |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.2.55-3 🚀
|
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.2.57-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀
|
Explanation of Change
Fixed Issues
$ #72889
PROPOSAL: #72889 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Precondition: User copy link via sharing options in Safari
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
The issue doesn't occur.
Android: mWeb Chrome
The issue doesn't occur.
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.safari.mp4
MacOS: Chrome / Safari
The issue doesn't occur.
MacOS: Desktop
The issue doesn't occur.