Fix input loses focus when switching to another tab#736
Merged
cead22 merged 1 commit intoOct 31, 2025
Merged
Conversation
16 tasks
|
@jmusial bump on this review please |
Collaborator
|
@cead22 sorry, was OOO, looking now |
jmusial
approved these changes
Oct 31, 2025
Contributor
Author
|
@jmusial nope. You can merge this one. |
cead22
approved these changes
Oct 31, 2025
Contributor
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This happens after this #680. In that PR, we want to save the focused text input as outlined in the proposal Expensify/App#61521 (comment), so that
Keyboard.dismisswill work on live markdown. But since we can't directly access the text input state, we do it throughRNTextInput.State.focusTextInputon focus andRNTextInput.State.blurTextInputon blur.When we switch tabs, the input
onBluris triggered, so the input is blurred. In normal cases, the input doesn't lose focus even thoughonBluris called when switching tabs.Related Issues
Expensify: Expensify/App#72458
Manual Tests
web.mp4
Linked PRs