Update live markdown to fix focus lost when switching tabs#74036
Conversation
|
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari20251103004447591.mp4MacOS: Desktop |
|
@bernhardoj is this a known issue? 20251103005625955.mp4 |
|
@bernhardoj We should also bump the library on the hybrid app in parallel to avoid native build errors — similar to #70750 and #71187. I think you need to also open a PR in hybrid app. CC @cead22 |
|
Yes, it's a known issue https://expensify.slack.com/archives/C01GTK53T8Q/p1761955541563179 @ahmedGaber93 do you know how we can update the library on the hybrid app? (this is my first time 😅) |
|
@bernhardoj Open a PR on the old app as https://github.com/Expensify/Mobile-Expensify/pull/13701 |
|
No, I mean, how can I bump the library version on the old app, specifically the spec checksum? Do I need to clone the Mobile-Expensify, increase the library version, and then run pod install? Or is there a way to do it from App repo? |
I think you’ll need to clone it, but I’m not completely sure since I haven’t opened a PR on the old app before. |
|
Here is the Mobile-Expensify PR: https://github.com/Expensify/Mobile-Expensify/pullw/13760 |
ahmedGaber93
left a comment
There was a problem hiding this comment.
We should merge this in parallel with the oldDot PR https://github.com/Expensify/Mobile-Expensify/pull/13760
|
Unit tests are failing here, and there's conflicts on https://github.com/Expensify/Mobile-Expensify/pull/13760. Why do we need to merge them in parallel btw? |
|
Conflicts fixed.
I guess so that the HybridApp and standalone use the same versions. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cead22 in version: 9.2.47-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.47-1 🚀
|


Explanation of Change
Fixed Issues
$ #72458
PROPOSAL: #72458 (comment)
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13760
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
WEB only
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop