[HOLD for payment 2021-10-22] When I try to access the "Payments" page, I get stuck on a white screen

[michaelhaxhiu]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

• Open New Expensify
• Go to Settings (your avatar) > Payments
• Get stuck on a white screen

This white screen never clears:

Expected Result:

I should be able to access the Payments page on New Expensify (app or website)

Actual Result:

When I try to access the Payments page, I get stuck on a white screen.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Not able to access the Payments page.

Platform:

All

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.1.3-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: mhaxhiu
Slack conversation: n/a

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[laurenreidexpensify]

Ha caught me as I was just looking at my dailies. Okay so I can't replicate this in web - am I missing something in your steps?

[michaelhaxhiu]

Hmm I didn't do anything special on my side, it's reproducible every time for me.

[laurenreidexpensify]

Hmmm I can't repro this on Android. Gonna ask in open-source.

[Santhosh-Sellavel]

This issue is caused by the below line, but additionalData.bankName is expected here in bankAccount but seems not available here. cc: @stitesExpensify

App/src/pages/settings/Payments/PaymentMethodList.js

Line 90 in fa7cb60

const {icon, iconSize} = getBankIcon(bankAccount.additionalData.bankName);

We can modify above line as shown below, to fix this issue.

const {icon, iconSize} = getBankIcon(_.get(bankAccount, 'additionalData.bankName', ''));

[stitesExpensify]

Seems like a fine solution to me @Santhosh-Sellavel. @laurenreidexpensify want to make a job and hire him? Nice quick one line fix 😄

[laurenreidexpensify]

@stitesExpensify can you add the external label pls? thanks

[stitesExpensify]

Added!

[Santhosh-Sellavel]

@stitesExpensify Can I open up a PR for this?